Skip to content

rust-string_cache0.8: pin to Fedora 43 build commit 0823d01a166f#16389

Merged
christopherco merged 1 commit intotomls/base/mainfrom
tomls/base/rust-string_cache0.8
Apr 1, 2026
Merged

rust-string_cache0.8: pin to Fedora 43 build commit 0823d01a166f#16389
christopherco merged 1 commit intotomls/base/mainfrom
tomls/base/rust-string_cache0.8

Conversation

@binujp
Copy link
Copy Markdown
Contributor

@binujp binujp commented Mar 31, 2026

Pin rust-string_cache0.8 to upstream commit 0823d01a166f380d91468ed92c16bc57ad04398b (Fedora dist-git: rust-string_cache) to fetch sources from the commit used to build the current f43 package.

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./LICENSES-AND-NOTICES/SPECS/data/licenses.json, ./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md, ./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

What does the PR accomplish, why was it needed?

Change Log
  • Change
  • Change
  • Change
Does this affect the toolchain?

YES/NO

Associated issues
  • #xxxx
Links to CVEs
Test Methodology
  • Pipeline build id: xxxx

Pin rust-string_cache0.8 to upstream commit 0823d01a166f380d91468ed92c16bc57ad04398b
(Fedora dist-git: rust-string_cache) to fetch sources from the commit
used to build the current f43 package.
Copilot AI review requested due to automatic review settings March 31, 2026 22:14
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Pins rust-string_cache0.8 to the exact Fedora 43 dist-git commit used for the currently built f43 package, ensuring Azure Linux pulls matching sources even if the Fedora 43 snapshot date advances.

Changes:

  • Added a dedicated component definition to pin rust-string_cache0.8 to Fedora 43 commit 0823d01a166f....
  • Removed the now-dedicated rust-string_cache0.8 entry from components-full.toml to avoid duplication.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
base/comps/rust-string_cache0.8/rust-string_cache0.8.comp.toml Adds an upstream pin to a specific Fedora 43 dist-git commit for reproducible source selection.
base/comps/components-full.toml Drops the inline entry since the component now has a dedicated *.comp.toml file.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@@ -0,0 +1,5 @@
[components.'rust-string_cache0.8']
# Pin to the f43 commit used to build the current Fedora 43 package.
Copy link

Copilot AI Mar 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When pinning to a specific Fedora dist-git commit, please include a direct reference URL to the commit (and branch) in the comment block (e.g., the pattern used in base/comps/golang/golang.comp.toml). This makes it easy to audit/refresh the pin later and confirm it matches the intended f43 build input.

Suggested change
# Pin to the f43 commit used to build the current Fedora 43 package.
# Pin to the f43 commit used to build the current Fedora 43 package.
# Fedora dist-git commit (f43): https://src.fedoraproject.org/rpms/rust-string_cache/c/0823d01a166f380d91468ed92c16bc57ad04398b?branch=f43

Copilot uses AI. Check for mistakes.
@christopherco christopherco merged commit cdb7027 into tomls/base/main Apr 1, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants