Conversation
| [components.mlnx-ofa_kernel.build] | ||
| # Kernel version must match the kernel on the target VM. | ||
| # target_kernel_dist carries the full dist suffix including any pre-release tag. | ||
| defines = { target_kernel_version = "6.18.5.1", target_kernel_release = "3", target_kernel_dist = ".azl4" } |
There was a problem hiding this comment.
I saw offline discussion regarding how to keep this in sync with the kernel version via macros and such. Are you planning to hold this draft until that solution can be implemented?
| # | ||
| # | ||
|
|
||
| %global target_kernel_version 6.18.5.1 |
There was a problem hiding this comment.
Why are these also defined here?
| # | ||
| # Copyright (c) 2012 Mellanox Technologies. All rights reserved. | ||
| # | ||
| # This Software is licensed under one of the following licenses: |
There was a problem hiding this comment.
Is this the license for the spec or for the sources covered by it? Where did the spec come from, and how do we plan to ingest updates to it -- or have we hard-forked it?
| # MarinerOS 1.0 sets -fPIE in the hardening cflags | ||
| # (in the gcc specs file). | ||
| # This seems to break only this package and not other kernel packages. | ||
| %if "%{_vendor}" == "azl" || (0%{?rhel} >= 10) || (0%{?amzn} == 2023) |
There was a problem hiding this comment.
Are we certain this vendor macro lines up? This also won't work correctly for "stage1" (a.k.a. bootstrap) builds.
| %global IS_RHEL_VENDOR "%{_vendor}" == "redhat" || ("%{_vendor}" == "bclinux") || ("%{_vendor}" == "openEuler") | ||
| %global KMOD_PREAMBLE "%{_vendor}" != "openEuler" | ||
|
|
||
| # MarinerOS 1.0 sets -fPIE in the hardening cflags |
| %global non_kmp_pname %{_name}-modules | ||
|
|
||
| Summary: Infiniband HCA Driver | ||
| Name: mlnx-ofa_kernel |
There was a problem hiding this comment.
Should this still be the name of the package (i.e., with mlnx as a prefix)?
2 participants
Merge Checklist
All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)
*-staticsubpackages, etc.) have had theirReleasetag incremented../cgmanifest.json,./toolkit/scripts/toolchain/cgmanifest.json,.github/workflows/cgmanifest.json)./LICENSES-AND-NOTICES/SPECS/data/licenses.json,./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md,./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)*.signatures.jsonfilessudo make go-tidy-allandsudo make go-test-coveragepassSummary
POC spec to add DOCA OFED 3.3.0 (corresponding mlnx-ofa_kernel 26.01) for 4.0
Change Log
Does this affect the toolchain?
YES/NO
Associated issues
Links to CVEs
Test Methodology