Upgrade kubevirt to 1.7.0 and backport libvirt GSource memory leak fix#15712
Draft
aadhar-agarwal wants to merge 2 commits into3.0-devfrom
Draft
Upgrade kubevirt to 1.7.0 and backport libvirt GSource memory leak fix#15712aadhar-agarwal wants to merge 2 commits into3.0-devfrom
aadhar-agarwal wants to merge 2 commits into3.0-devfrom
Conversation
microsoft-github-policy-service
bot
added
Packaging
specs-extended
aadhar-agarwal
force-pushed
the
aadagarwal/upgrade-kubevirt-1.7
branch
from
baf00af to
9139554
Compare
- Remove CVE-2025-47913.patch (ssh/agent package no longer vendored) - Remove CVE-2025-64435.patch (fixed upstream via PR#15680) - Bump golang BuildRequires to >= 1.24 per upstream PR#15784 Signed-off-by: Aadhar Agarwal <aadagarwal@microsoft.com>
aadhar-agarwal
force-pushed
the
aadagarwal/upgrade-kubevirt-1.7
branch
from
9139554 to
c9b4e2c
Compare
Contributor
|
/lgtm |
Backport upstream commit 98f1cf88 to fix a memory leak in the virNetClientIO() function where GSource objects were not being properly released. This addresses the virt-launcher memory growth issue reported in KubeVirt environments (kubevirt/kubevirt#15996), where the leak causes OOM kills of virt-launcher pods. Upstream reference: https://gitlab.com/libvirt/libvirt/-/commit/98f1cf88fa7e0f992d93f376418fbfb3996a9690
aadhar-agarwal
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge Checklist
All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)
*-staticsubpackages, etc.) have had theirReleasetag incremented../cgmanifest.json,./toolkit/scripts/toolchain/cgmanifest.json,.github/workflows/cgmanifest.json)./LICENSES-AND-NOTICES/SPECS/data/licenses.json,./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md,./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)*.signatures.jsonfilessudo make go-tidy-allandsudo make go-test-coveragepassSummary
What does the PR accomplish, why was it needed?
Change Log
kubevirt
golang.org/x/crypto/ssh/agentpackage. The directory was removed in PR #15478 ("cleanup(virtctl): Drop native ssh and scp clients"), which eliminated the native SSH/SCP clients from virtctl and removed the dependency on the vulnerable package entirely.pkg/controller/controller_ref.gofile no longer exists in 1.7.0 - it was completely removed and replaced with secure standard Kubernetes API calls.BuildRequires: golang >= 1.24change is required because kubevirt 1.7.0 updated its Go version via PR #15784: "Build KubeVirt with go v1.24.7". The project'sgo.modnow declaresgo 1.24.0, making Go 1.24+ mandatory for building.libvirt
Does this affect the toolchain?
NO
Associated memory leak fixes
kubevirt:
libvirt:
Links to CVEs
Test Methodology