Skip to content

Add copilot agent to review specs#15662

Draft
dmcilvaney wants to merge 19 commits intomicrosoft:tomls/base/mainfrom
dmcilvaney:damcilva/spec_agent
Draft

Add copilot agent to review specs#15662
dmcilvaney wants to merge 19 commits intomicrosoft:tomls/base/mainfrom
dmcilvaney:damcilva/spec_agent

Conversation

@dmcilvaney
Copy link
Contributor

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./LICENSES-AND-NOTICES/SPECS/data/licenses.json, ./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md, ./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

What does the PR accomplish, why was it needed?

Change Log
  • Change
  • Change
  • Change
Does this affect the toolchain?

YES/NO

Associated issues
  • #xxxx
Links to CVEs
Test Methodology
  • Pipeline build id: xxxx

- Add review tool in [spec-review.agent.md](.github/agents/spec-review.agent.md)
- Review only changed .spec files with concurrency control and artifacts
  in [.github/workflows/spec-review.yml](.github/workflows/spec-review.yml)
- Add inline annotations and richer PR comments via
  [`create_check_annotations.py`](.github/workflows/scripts/create_check_annotations.py)
  and [`format_pr_comment.py`](.github/workflows/scripts/format_pr_comment.py)
- Enhance reporting/validation with [`spec_review_schema.py`](.github/workflows/scripts/spec_review_schema.py)
  and orchestrate runs via [`spec_review.sh`](.github/workflows/scripts/spec_review.sh)
@dmcilvaney
Copy link
Contributor Author

Need to configure auth still for the main repo, currently configured for testing in my fork

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant