Add Kdump option to disable reboot after save_core#10581
Open
nangelastro wants to merge 1 commit intomicrosoft:3.0-devfrom
Open
Add Kdump option to disable reboot after save_core#10581nangelastro wants to merge 1 commit intomicrosoft:3.0-devfrom
nangelastro wants to merge 1 commit intomicrosoft:3.0-devfrom
Conversation
234a553 to
0d883bb
Compare
Author
@microsoft-github-policy-service agree company="Microsoft" |
gjswalling
approved these changes
Sep 30, 2024
gjswalling
suggested changes
Oct 1, 2024
SPECS/kexec-tools/kdump.conf
Outdated
| #dracut_args --omit-drivers "cfg80211 snd" --add-drivers "ext2 ext3" | ||
| #fence_kdump_args -p 7410 -f auto -c 0 -i 10 | ||
| #fence_kdump_nodes node1 node2 | ||
| #disable_crash_dump_reboot 0 No newline at end of file |
Contributor
There was a problem hiding this comment.
please add new line at end of the file. I found description here: https://stackoverflow.com/a/77201456/22141712
0d883bb to
32cd179
Compare
gjswalling
approved these changes
Oct 1, 2024
32cd179 to
094eb90
Compare
094eb90 to
4612f09
Compare
91b8c61 to
d959740
Compare
d959740 to
c3d512b
Compare
1145828 to
5438235
Compare
5438235 to
9f3c740
Compare
By default, Kdump copies the entire vmcore to the disk and reboots the system afterwards. While this works in most cases, it does not work for systems hosted in RAM where the crash dump will be lost once rebooted. To support this scenario, a new option in the kdump.conf, save_core_to_ram, is added and commented out. Setting this option to 1 will allow a compressed crash dump to be produced by utilizing the core_collector option if specified, otherwise the dmesg log will be extracted from the vmcore. This is especially necessary because there is no disk to save the dump to, and there is not enough space in the pre-allocated crashkernel memory space to save an entire vmcore.
9f3c740 to
cb14ab9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge Checklist
All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)
*-staticsubpackages, etc.) have had theirReleasetag incremented../cgmanifest.json,./toolkit/scripts/toolchain/cgmanifest.json,.github/workflows/cgmanifest.json)./LICENSES-AND-NOTICES/SPECS/data/licenses.json,./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md,./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)*.signatures.jsonfilessudo make go-tidy-allandsudo make go-test-coveragepassSummary
What does the PR accomplish, why was it needed?
By default, Kdump copies the entire vmcore to the disk and reboots the
system afterwards. While this works in most cases, it does not work for
systems hosted in RAM where the crash dump will be lost once rebooted.
To support this scenario, a new option in the kdump.conf,
save_core_to_ram, is added and commented out. Setting this option to 1
will allow a compressed crash dump to be produced by utilizing the
core_collector option if specified, otherwise the dmesg log will be
extracted from the vmcore. This is especially necessary because there is
no disk to save the dump to, and there is not enough space in the
pre-allocated crashkernel memory space to save an entire vmcore.
Change Log
Does this affect the toolchain?
NO
Test Methodology
<date>/vmcore