Add support for InstallationToken in kubelogininstallerV0#21688
Draft
zhangyuan wants to merge 2 commits intomicrosoft:masterfrom
Draft
Add support for InstallationToken in kubelogininstallerV0#21688zhangyuan wants to merge 2 commits intomicrosoft:masterfrom
zhangyuan wants to merge 2 commits intomicrosoft:masterfrom
Conversation
Author
|
@microsoft-github-policy-service agree |
Author
|
I don't have permissions to install non-official tasks to our origination, so I can't validate the change. I'm not sure if Azure DevOps can well handle InstallationToken from Github. Can someone point me how to validate? |
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
When Github Connection uses InstallationToken, the task raises error.
Task Name
KubeloginInstallerV0
Description
If the scheme of
githubEndpointObjectisInstallationToken, returnAccessTokenRisk Assessment (Low / Medium / High)
Assess the level of risk and provide reasoning (e.g., scope, impact, backward compatibility).
Change Behind Feature Flag (Yes / No)
No.
Tech Design / Approach
N/A
Documentation Changes Required (Yes/No)
No.
The document incides it supports
InstallationToken, actually not. So no updates to documents.Unit Tests Added or Updated (Yes / No)
No.
Additional Testing Performed
List all other tests performed (manual or automated, including integration, regression, scenario tests, etc.).
Logging Added/Updated (Yes/No)
No.
Telemetry Added/Updated (Yes/No)
No.
Rollback Scenario and Process (Yes/No)
No.
Dependency Impact Assessed and Regression Tested (Yes/No)
No.
Checklist