Fixing unknown flags like --client and --save error in HelmDeployV1 task flags #21682
Merged
v-abhishera merged 15 commits intomasterfrom Jan 14, 2026
Merged
Fixing unknown flags like --client and --save error in HelmDeployV1 task flags #21682v-abhishera merged 15 commits intomasterfrom
v-abhishera merged 15 commits intomasterfrom
Conversation
…sion under UseHelmVersionV3orHigher FF
- Corrected helm version command mock to "helm version --short --client" to match actual argument order from helmcli.ts
This reverts commit 1495a3d.
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
… other helm command
…est setup - Updated all references in test file and shared test utilities - Fixed helm version command flag order (--client --short) - Added mock for getPipelineFeature to control version detection behavior - Corrected --save flag logic in package command tests
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
- Test both true and false scenarios - Mock legacy (--client --short) and new (--short) commands
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
manolerazvan
approved these changes
Jan 13, 2026
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context Fixing unknown flags like --client and --save error in HelmDeployV1 task flags https://dev.azure.com/mseng/AzureDevOps/_workitems/edit/2343801
Task Name HelmDeployV1
Description
The --client and --save flags are not supported in Helm v3 or later versions, which caused the unknown flags error in the task command that checks the Helm version first to determine if it is v3 or higher.
Risk Assessment Low
Change Behind Feature Flag Yes
Unit Tests Added or Updated Yes
Checklist