fix: disable validation checks when passing --permissive-config#216
Open
dmcilvaney wants to merge 1 commit into
Open
fix: disable validation checks when passing --permissive-config#216dmcilvaney wants to merge 1 commit into
dmcilvaney wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Extends --permissive-config to also relax post-load cross-reference validation. Previously the flag only affected TOML decoding (allowing unknown fields); semantic checks (component-group membership, package-group membership, image/test-suite references) still failed hard. The PR threads the permissive flag through ProjectConfig.validate so these three checks become slog.Info warnings, supporting future work loading historical overlays where references may target entities defined in another revision.
Changes:
- Added internal
(*ProjectConfig).validate(permissive bool)that downgrades 3 cross-reference checks to log messages when permissive. - Public
Validate()retained, delegating tovalidate(false)to preserve existing behavior. loadAndResolveProjectConfignow passespermissiveConfigParsinginto the newvalidatecall.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| internal/projectconfig/project.go | Splits Validate into a permissive-aware internal validate; demotes 3 cross-ref errors to info logs when permissive. |
| internal/projectconfig/loader.go | Forwards permissiveConfigParsing to the new internal validate. |
dmcilvaney
force-pushed
the
damcilva/historic_overlays
branch
from
75b708f to
fbbded6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needed for some future work to load and apply historic overlays.