Update Components to address Component Governance issues#75
Merged
Conversation
Contributor
MSNev
commented
May 12, 2025
- remove grunt-contrib-qunit
- update puppeteer
There was a problem hiding this comment.
Pull Request Overview
This PR updates components to address Component Governance issues by removing the grunt-contrib-qunit dependency across various package files and updating the puppeteer version.
- Removed grunt-contrib-qunit (and related dependencies like tar-fs) from several package.json files and the gruntfile
- Updated puppeteer to version 24.8.2 and added eventemitter2 as a dependency
- Added tools/grunt-tasks/chrome/bridge.js, which appears to vendor some grunt-contrib-qunit related functionality
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tools/rollup-plugin-uglify3-js/package.json | Removed grunt-contrib-qunit and tar-fs from devDependencies |
| tools/grunt-tasks/chrome/bridge.js | Added new file that implements QUnit message bridging, but still references grunt-contrib-qunit |
| package.json | Removed grunt-contrib-qunit and tar-fs; updated puppeteer version and added eventemitter2 |
| gruntfile.js | Removed loading of grunt-contrib-qunit task |
| common/Tests/Framework/package.json | Removed grunt-contrib-qunit and tar-fs from devDependencies |
| applicationinsights-react-native/package.json | Removed grunt-contrib-qunit and tar-fs from devDependencies |
- remove grunt-contrib-qunit - update puppeteer
9977b2a to
1cec33e
Compare
Karlie-777
approved these changes
May 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.