.NET: Fix flaky Foundry recovery test synchronization - #7817
.NET: Fix flaky Foundry recovery test synchronization#7817Roger Barreto (rogerbarreto) wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Pull request overview
Synchronizes the Foundry recovery test with persisted checkpoint state instead of live HTTP output.
Changes:
- Polls the persisted response file for expected output.
- Retries file-read failures and improves timeout diagnostics.
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
| return; | ||
| } | ||
| } | ||
| catch (IOException ex) |
There was a problem hiding this comment.
MAF Automated Review — Iteration 1
Result: No findings
Scope: full PR (1 commit(s)): 03e9ab871403
Model: gpt-5.6-sol
Overview
This test-only change replaces synchronization against live HTTP output with polling of the durable response envelope before stopping the first host. Exact ordered-output checks, bounded polling, post-shutdown persistence assertions, and end-to-end recovery assertions constrain the behavior well. No Critical, High, or Medium defect was established.
Reviewed the supplied pull-request change set across correctness, security/reliability, architecture, and failure behavior.
No publishable findings remained after source verification for this scope.
Motivation & Context
The Foundry two lifetime recovery test could read the response file stored on disk immediately after the live HTTP response exposed new output. AgentServer writes that output during the next saved recovery point, which the code calls a checkpoint, so the test could stop the host while the file still contained the previous checkpoint.
Description & Review Guide
IOExceptionraised while the checkpoint writer briefly owns the file.Related Issue
Fixes #7816
Contribution Checklist
breaking changelabel (or add "[BREAKING]" to the title prefix, before or after any language prefix). A workflow keeps the label and title prefix in sync automatically.