Python: Include arguments for zero-argument Foundry eval tool calls - #7724
Open
Luis Rodriguez (luisangelrod) wants to merge 1 commit into
Open
Python: Include arguments for zero-argument Foundry eval tool calls#7724Luis Rodriguez (luisangelrod) wants to merge 1 commit into
Luis Rodriguez (luisangelrod) wants to merge 1 commit into
Conversation
Luis Rodriguez (luisangelrod)
temporarily deployed
to
github-app-auth
August 18, 2026 14:08 — with
GitHub Actions
Inactive
Luis Rodriguez (luisangelrod)
temporarily deployed
to
github-app-auth
August 18, 2026 14:08 — with
GitHub Actions
Inactive
Luis Rodriguez (luisangelrod)
temporarily deployed
to
github-app-auth
August 18, 2026 14:08 — with
GitHub Actions
Inactive
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds coverage and adjusts the eval conversion output so tool calls always include an arguments object, even when the tool call has zero/empty arguments.
Changes:
- Add tests for assistant tool calls with
arguments=Noneandarguments={}. - Update
AgentEvalConverter.convert_messageto always emit anargumentsfield, defaulting to{}when missing.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| python/packages/foundry/tests/test_foundry_evals.py | Adds regression tests to ensure tool-call arguments are normalized to {} for zero/empty args. |
| python/packages/core/agent_framework/_evaluation.py | Normalizes tool-call conversion output to always include arguments (defaults to {} when None). |
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
Luis Rodriguez (luisangelrod)
temporarily deployed
to
github-app-auth
August 18, 2026 14:09 — with
GitHub Actions
Inactive
Luis Rodriguez (luisangelrod)
marked this pull request as ready for review
August 18, 2026 14:11
Luis Rodriguez (luisangelrod)
temporarily deployed
to
github-app-auth
August 18, 2026 14:11 — with
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation & Context
Foundry evaluation conversion currently omits the
argumentsfield when a function call hasNoneor an empty object for its arguments. This produces an incomplete tool-call record for valid zero-argument tools. The converter should emit an empty object so the evaluation payload remains schema-consistent.Description & Review Guide
arguments, using an empty object when the source value isNone. Regression tests cover bothNoneand an explicitly empty argument object.Related Issue
Fixes #7714
Contribution Checklist
breaking changelabel (or add "[BREAKING]" to the title prefix, before or after any language prefix) — a workflow keeps the label and title prefix in sync automatically.