Skip to content

Python: Fix history provider isolation bypass in Responses-style continuation #4579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
coding-shalabh wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Python: Fix history provider isolation bypass in Responses-style continuation #4579

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 22 additions & 3 deletions python/packages/core/agent_framework/_agents.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1090,11 +1090,30 @@ async def _prepare_run_context(
additional_function_arguments["session"] = active_session

# Build options dict from run() options merged with provided options
# Determine conversation_id: honor explicit runtime option first, then conditionally forward service_session_id
explicit_conversation_id = opts.pop("conversation_id", None)

# Check if any history provider has load_messages=False (meaning it wants to manage history itself)
has_history_provider_disabling_load = any(
isinstance(p, BaseHistoryProvider) and not p.load_messages
for p in self.context_providers
)

# Only auto-forward service_session_id if:
# 1. No explicit conversation_id provided in runtime options
# 2. No history provider is explicitly disabling message loading
should_forward_service_session = (
active_session
and active_session.service_session_id
and not explicit_conversation_id
and not has_history_provider_disabling_load
)

run_opts: dict[str, Any] = {
"model_id": opts.pop("model_id", None),
"conversation_id": active_session.service_session_id
if active_session
else opts.pop("conversation_id", None),
"conversation_id": explicit_conversation_id if explicit_conversation_id else (
active_session.service_session_id if should_forward_service_session else None
),
"allow_multiple_tool_calls": opts.pop("allow_multiple_tool_calls", None),
"additional_function_arguments": additional_function_arguments or None,
"frequency_penalty": opts.pop("frequency_penalty", None),
Expand Down