Python: Add sample on how to share a thread between agents in a workflow #3405
Conversation
github-actions
bot
changed the title
Python Test Coverage Report •
Python Unit Test Overview
|
||||||||||||||||||||||||||||||
There was a problem hiding this comment.
Let's also please add this new sample to the workflows/README.md.
|
|
||
| shared_thread = writer.get_new_thread() | ||
| # Set the message store to store messages in memory. | ||
| shared_thread.message_store = ChatMessageStore() |
There was a problem hiding this comment.
I think a better way would be to initialize it via chat_message_store_factory. I noticed that this parameter exists in BaseChatClient.as_agent method, but not in AzureAIProjectAgentProvider. We can add this parameter to provider, pass it to the place where we create ChatAgent, and then in this example, when invoking create_agent, we could also pass chat_message_store_factory=ChatMessageStore.
There was a problem hiding this comment.
This pattern feels a bit weird indeed. A thread is a parallel concept to agent but the chat message store live in the agent.
When I was creating the sample, my first impression was that I could pass in the message store when I call get_new_thread(). Have we considered it?
Also, the fact that we have to also set store to False to have message to actually be stored in the message store is also great.
| print(f"User: {query1}") | ||
| result1 = await agent.run(query1, thread=thread, store=False) | ||
| result1 = await agent.run( | ||
| query1, thread=thread, options=OpenAIResponsesOptions(store=False) |
There was a problem hiding this comment.
let's focus on showing to avoid unnecessary concepts:
| query1, thread=thread, options=OpenAIResponsesOptions(store=False) | |
| query1, thread=thread, options={"store": False} |
|
|
||
| workflow = ( | ||
| WorkflowBuilder() | ||
| .register_agent(lambda: writer, "writer", agent_thread=shared_thread) |
There was a problem hiding this comment.
please add some parameter names, because I have no clue what I'm reading here, when I looked up the definition it made a bit more sense, but plain reading this is hard!
| "Write a tagline for a budget-friendly eBike.", | ||
| # Keyword arguments will be passed to each agent call. | ||
| # Setting store=False to avoid storing messages in the service for this example. | ||
| options=OpenAIResponsesOptions(store=False), |
5 participants
Motivation and Context
Part of #761
Description
python/samples/getting_started/agents/azure_ai/azure_ai_with_thread.pywherestore=Falseno longer has effects.Contribution Checklist