.NET: fix: include MessageId in AGUIToolMessage to ChatMessage transformation #3367
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
changed the title
Author
|
@microsoft-github-policy-service agree |
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request fixes a bug where the MessageId property was not being set when converting AGUIToolMessage to ChatMessage objects. The fix ensures consistency with how other message types (assistant and default messages) already handle MessageId preservation during conversion.
Changes:
- Sets
MessageIdproperty in theAsChatMessagesmethod forAGUIToolMessageconversions - Adds test assertions to verify MessageId is correctly preserved for tool messages
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| dotnet/src/Microsoft.Agents.AI.AGUI/Shared/AGUIChatMessageExtensions.cs | Adds MessageId assignment to AGUIToolMessage conversion, making it consistent with other message type conversions |
| dotnet/tests/Microsoft.Agents.AI.AGUI.UnitTests/AGUIChatMessageExtensionsTests.cs | Adds four assertions across different test cases to verify MessageId is correctly set for tool message conversions |
MaciejWarchalowski
force-pushed
the
agui-tool-message-transformation-3365
branch
from
4337513 to
e9a1086
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request ensures that the
MessageIdproperty is correctly set when converting AGUIToolMessage toChatMessageobjects, and updates the corresponding unit tests to verify this behavior. References #3365Enhancements to message conversion logic:
AGUIChatMessageExtensions.cs: Sets theMessageIdproperty when creating aChatMessagefrom a AGUIToolMessage in theAsChatMessagesmethod.Testing improvements:
AGUIChatMessageExtensionsTests.cs: Adds assertions to multiple test cases to verify that theMessageIdof the resultingChatMessageis correctly assigned. [1] [2] [3] [4]