Disable VS sideloading telemetry DLLs to fix BinSkim BA2022#609
Open
alexlamtest wants to merge 1 commit intomainfrom
Open
Disable VS sideloading telemetry DLLs to fix BinSkim BA2022#609alexlamtest wants to merge 1 commit intomainfrom
alexlamtest wants to merge 1 commit intomainfrom
Conversation
Setting AppxLogTelemetryFromSideloadingScript to false prevents VS's MSBuild AppxPackage targets from copying SHA-1 signed telemetry DLLs (Microsoft.Diagnostics.Tracing.EventSource.dll, etc.) into sample app packages. These DLLs fail BinSkim BA2022 (SignSecurely). The telemetry DLLs are not needed for sample app functionality - they are only used for VS sideloading telemetry collection. Fixes: https://dev.azure.com/microsoft/OS/_workitems/edit/57941542 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Collaborator
Author
|
/azp run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Setting
AppxLogTelemetryFromSideloadingScripttofalseprevents VS's MSBuild AppxPackage targets (_AddWindowsInstallScriptToTestLayout) from copying SHA-1 signed telemetry DLLs (Microsoft.Diagnostics.Tracing.EventSource.dll,Microsoft.VisualStudio.Telemetry.dll, etc.) into sample app packages. These DLLs fail BinSkim BA2022 (SignSecurely).The telemetry DLLs are only used for VS sideloading telemetry collection and are not needed for sample app functionality.
Fix identified and verified by Scott Jones.
Fixes: https://dev.azure.com/microsoft/OS/_workitems/edit/57941542
How built:
How tested: