netvmini/rssv2: fix mixed-width comparison in processor lookup loop#1383
Merged
5an7y-Microsoft merged 2 commits intoMay 21, 2026
Merged
Conversation
Summary This PR addresses a static-analysis warning in rssv2.c related to comparing values of different integer widths in a loop condition. Changes - Updated the loop index type in NICSetRSSv2FindProcessorInRssSet from UINT8 to ULONG to match RssProcessorCount width. - Added an explicit cast when returning the found index: return (UINT8)index; to preserve the function’s return type and behavior. Why Using matching integer widths in loop comparisons avoids analyzer warnings and reduces risk of subtle boundary issues. Impact No functional behavior change is intended; this is a type-safety and code-quality fix for warning cleanup.
amrutha-chandramohan
approved these changes
May 14, 2026
Author
|
@5an7y-Microsoft , could you please merge this PR? Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses a static-analysis warning in rssv2.c related to comparing values of different integer widths in a loop condition.
Changes
Why
Using matching integer widths in loop comparisons avoids analyzer warnings and reduces risk of subtle boundary issues.
Impact
No functional behavior change is intended; this is a type-safety and code-quality fix for warning cleanup.