Generate custom container name on empty input#40432
Open
Generate custom container name on empty input#40432
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR changes WSLC container creation so that when a caller does not provide a container name, the service generates a human-readable name (using a descriptor + mountain word list), and adds tests that validate the generated name format and uniqueness.
Changes:
- Add descriptor/mountain word lists for generated container names.
- Generate a unique container name during
WSLCSession::CreateContainer()when no name is provided. - Expand WSLC tests to validate the generated name format and uniqueness; update test include paths accordingly.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
src/windows/wslcsession/WSLCSession.cpp |
Adds container name generation helpers and injects generated names into container creation when name is absent. |
src/windows/wslcsession/ContainerNameGenerator.h |
Introduces the descriptor/mountain constants used for name generation and test validation. |
test/windows/WSLCTests.cpp |
Adds coverage for generated-name format and uniqueness when creating unnamed containers. |
test/windows/CMakeLists.txt |
Adds include path so tests can include the new name constants header. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
When containerOptions.Name is empty, generate our own container name.
PR Checklist
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed
Added tests.