Updated ADMX for WSLC#40422
Conversation
benhillis
left a comment
benhillis
left a comment
There was a problem hiding this comment.
Some suggestions / questions.
| <parentCategory ref="WSLContainerCLI" /> | ||
| <supportedOn ref="windows:SUPPORTED_Windows10" /> | ||
| <elements> | ||
| <text id="WSLContainerCLIRegistryAllowlist_Input" valueName="WSLContainerCLIRegistryAllowlist" /> |
There was a problem hiding this comment.
No idea if ADMX supports that or not. But a string seems easier for us to parse! So I'd opt for keeping it as a string
There was a problem hiding this comment.
ADMX supports having a list element. I don't know how this looks in Intune, but for the local Group Policy Editor, the experience for this with a list is IMO better than with a string. Especially once you have many or long values.
As an example, these are the first two policies that I found using string and list.
| <string id="AllowWSLContainerCLIExplain">This policy controls whether the WSL Container CLI (wslc.exe) can be used on this machine. When enabled or not configured, users can use the WSL Container CLI. When set to disabled, the WSL Container CLI is blocked for all users.</string> | ||
|
|
||
| <string id="WSLContainerCLIRegistryAllowlist">Allowlist for WSL container CLI registries</string> | ||
| <string id="WSLContainerCLIRegistryAllowlistExplain">When enabled, the WSL Container CLI will only be allowed to pull images from the registries listed here. Specify registries as a semicolon-separated list of hostnames (e.g. "registry1.example.com;registry2.example.com"). |
There was a problem hiding this comment.
What about when the policy is disabled or not configured?
There was a problem hiding this comment.
Made the verbage clearer
There was a problem hiding this comment.
I don't think it's clear what happens when you disable the policy. Does it mean "there is no allowlist, so you cannot use any registry" or "there is no allowlist, so you can use any registry"
| <string id="WSLContainers">WSL Containers</string> | ||
| <string id="WSLContainerCLI">WSL Container CLI</string> | ||
| <string id="WSLContainerAPI">WSL Container API</string> | ||
| <string id="WSLContainer">WSL Container</string> |
Summary of the Pull Request
Updated ADMX values for WSLC controls.
PR Checklist
Completed PR checklist, since it's just an ADMX no big changes or effort needed from the checklist.
Detailed Description of the Pull Request / Additional comments
Simple ADMX change.
Validation Steps Performed
Validated ADMX compiles (It's known that the logic isn't implemented yet)