[not for review] Investigate ARM test failure in P0811R3_midpoint_lerp - #6386
Open
statementreply wants to merge 2 commits into
Open
[not for review] Investigate ARM test failure in P0811R3_midpoint_lerp#6386statementreply wants to merge 2 commits into
P0811R3_midpoint_lerp#6386statementreply wants to merge 2 commits into
Conversation
|
Azure Pipelines: Successfully started running 1 pipeline(s). There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
Pull request overview
Narrows CI to reproduce the ARM64 floating-point exception failure.
Changes:
- Re-enables ARM64 exception validation.
- Restricts CI to ARM64 and the affected test.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
tests/std/tests/P0811R3_midpoint_lerp/test.cpp |
Removes ARM64 exception-check workaround. |
azure-pipelines.yml |
Runs only ARM64 testing. |
azure-devops/cmake-configure-build.yml |
Filters testing to the midpoint/lerp test. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| - Build_ARM64 | ||
| - Build_ARM64EC | ||
| - Configure_Tests | ||
| dependsOn: [] |
| - '--order=lexical' | ||
| - '--num-shards=$(System.TotalJobsInPhase)' | ||
| - '--run-shard=$(System.JobPositionInPhase)' | ||
| - '--filter=P0811R3_midpoint_lerp' |
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (2)
azure-pipelines.yml:14
- This leaves the repository's primary PR pipeline with only the ARM64 test stage, so code-format validation and all x64, x86, and ARM64EC build/test coverage disappear for every PR using this pipeline. Keep the normal stages intact and move this focused investigation to a separate temporary/manual pipeline (or gate the reduced graph behind an explicit diagnostic parameter) before merging.
dependsOn: []
azure-devops/cmake-configure-build.yml:28
- This filter is added to the shared
cmake-configure-build.ymldefault, which is also reached by all three jobs inazure-devops/asan-pipeline.yml:30,49,68. Those scheduled ASan jobs will therefore run only this test instead of the ASan suite. Thread an optionallitFlags/filter parameter throughbuild-and-test.ymland set it only on the investigative ARM64 job.
- '--filter=P0811R3_midpoint_lerp'
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (2)
azure-pipelines.yml:14
- The production pipeline now contains only this independent ARM64 stage; code-format validation and the x64, x86, and ARM64EC build/test stages have all been removed. This would allow regressions on those supported targets to merge undetected. Restore the normal stage matrix after the investigation.
dependsOn: []
azure-devops/cmake-configure-build.yml:28
- This shared configure template now hard-codes a filter for one test, so every current or future
build-and-test.ymlcaller silently excludes the rest of the test suite. Remove this diagnostic filter before merging, or expose it as an optional parameter passed only by a dedicated investigation pipeline.
- '--filter=P0811R3_midpoint_lerp'
| #if defined(_M_ARM64) || defined(_M_ARM64EC) // TRANSITION, GH-5685 | ||
| return true; | ||
| #else // ^^^ workaround / no workaround vvv | ||
| return fetestexcept(except_mask) == (expected_excepts & except_mask); |
StephanTLavavej
added
ARM64
statementreply
changed the title
P0811R3_midpoint_lerpP0811R3_midpoint_lerp
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not for review