Add Neon implementation of bitset_to_string#6153
Open
hazzlim wants to merge 3 commits intomicrosoft:mainfrom
Open
Add Neon implementation of bitset_to_string#6153hazzlim wants to merge 3 commits intomicrosoft:mainfrom
bitset_to_string#6153hazzlim wants to merge 3 commits intomicrosoft:mainfrom
Conversation
hazzlim
commented
Mar 11, 2026
This comment was marked as resolved.
This comment was marked as resolved.
StephanTLavavej
added
performance
This comment was marked as resolved.
This comment was marked as resolved.
StephanTLavavej
approved these changes
Mar 16, 2026
Member
|
I'm mirroring this to the MSVC-internal repo. Please notify me if any further changes are pushed, otherwise no action is required. |
StephanTLavavej
added a commit
to StephanTLavavej/STL
that referenced
this pull request
Mar 21, 2026
StephanTLavavej
added a commit
to StephanTLavavej/STL
that referenced
this pull request
Mar 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a Neon implementation of
bitset_to_string.There's a slightly ugly workaround for DevCom-11056873 which hopefully isn't deemed to egregious.
Benchmark results ⏲️
BM_bitset_to_string<15, char>BM_bitset_to_string<64, char>BM_bitset_to_string_large_single<512, char>BM_bitset_to_string_large_single<2048, char>BM_bitset_to_string<7, wchar_t>BM_bitset_to_string<64, wchar_t>BM_bitset_to_string_large_single<512, wchar_t>BM_bitset_to_string_large_single<2048, wchar_t>