Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions docs/changes/newsfragments/+dynacool-fixes.improved_driver
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
Fixed three bugs in :class:`qcodes.instrument_drivers.QuantumDesign.DynaCoolPPMS.DynaCool.DynaCool`
that prevented the driver from instantiating and from updating the
``temperature_setpoint`` cache:

- ``block_while_ramping_temperature`` is now created with ``set_cmd=None`` /
``get_cmd=None`` so it behaves as a settable cache-only parameter, instead of
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file should be named 8097.improved_driver

``set_cmd=False`` / ``get_cmd=False`` which made it read-only and rejected
the supplied ``initial_value``.
- Removed the duplicate ``instrument=self`` argument from the
``blocking_t_state_check_interval`` parameter creation, which is supplied
automatically by ``add_parameter`` and was raising on construction.
- Fixed an ``AttributeError`` when setting the temperature: the cache update
in ``_set_temperature_and_state`` now correctly references
``self.temperature_setpoint`` rather than the non-existent ``self.setpoint``.
Original file line number Diff line number Diff line change
Expand Up @@ -84,15 +84,14 @@ def __init__(
label="Block instrument while ramping temperature",
initial_value=False,
vals=vals.Bool(),
get_cmd=False,
set_cmd=False,
get_cmd=None,
set_cmd=None,
)
"""Parameter block_while_ramping_temperature, when set to True,
will block further interaction while temperature is ramping to setpoint."""

self.blocking_t_state_check_interval: Parameter = self.add_parameter(
name="blocking_t_state_check_interval",
instrument=self,
initial_value=0.5,
unit="s",
vals=vals.Numbers(0, 60),
Expand Down Expand Up @@ -434,7 +433,7 @@ def _temp_setter(
while self.temperature_state() != "stable":
sleep(self.blocking_t_state_check_interval())

self.setpoint.cache._set_from_raw_value(values[0])
self.temperature_setpoint.cache._set_from_raw_value(values[0])

def write(self, cmd: str) -> None:
"""
Expand Down
Loading