-
Notifications
You must be signed in to change notification settings - Fork 354
Add doctests #8072
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jenshnielsen
wants to merge
8
commits into
microsoft:main
Choose a base branch
from
jenshnielsen:add_doctests
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add doctests #8072
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
aa83232
Fix DotDict.__getattr__ to raise AttributeError instead of KeyError
jenshnielsen ed36de4
Enable doctest collection for src/ without errors
jenshnielsen 15a687b
Convert illustrative code blocks to runnable doctests where possible
jenshnielsen 327e5b4
Skip deprecated driver modules during doctest collection
jenshnielsen 9695189
Enable warnings as error
jenshnielsen c566b36
Switch shellcheck hook to shellcheck-py for cross-platform support
jenshnielsen 539d959
Collect doctests from src
jenshnielsen 9b4b135
Make one more doctest run
jenshnielsen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| import os | ||
| from pathlib import Path | ||
|
|
||
| # Drivers that require optional third-party libraries not generally available. | ||
| # These must be excluded from doctest collection to avoid ImportErrors. | ||
| collect_ignore_glob = [ | ||
| os.path.join("Galil", "*"), | ||
| os.path.join("Minicircuits", "*"), | ||
| os.path.join("QuantumDesign", "DynaCoolPPMS", "private", "*"), | ||
| ] | ||
|
|
||
|
|
||
| def _find_deprecated_driver_modules() -> list[str]: | ||
| """ | ||
| Scan for deprecated driver alias modules that emit deprecation warnings | ||
| on import. Importing these during doctest collection triggers noisy | ||
| warnings and serves no purpose since they contain no doctests. | ||
| """ | ||
| drivers_dir = Path(__file__).parent | ||
| deprecated: list[str] = [] | ||
| for path in sorted(drivers_dir.rglob("*.py")): | ||
| try: | ||
| text = path.read_text(encoding="utf-8") | ||
| except Exception: | ||
| continue | ||
| if "module is deprecated" in text: | ||
| deprecated.append(str(path.relative_to(drivers_dir))) | ||
| return deprecated | ||
|
|
||
|
|
||
| collect_ignore = _find_deprecated_driver_modules() |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Readd comment