Skip to content

Rigol + R&S drivers avoid internal dependency on dynamic attributes#7910

Open
jenshnielsen wants to merge 4 commits intomicrosoft:mainfrom
jenshnielsen:jenshnielsen/strict_rigol
Open

Rigol + R&S drivers avoid internal dependency on dynamic attributes#7910
jenshnielsen wants to merge 4 commits intomicrosoft:mainfrom
jenshnielsen:jenshnielsen/strict_rigol

Conversation

@jenshnielsen
Copy link
Collaborator

@jenshnielsen jenshnielsen commented Mar 6, 2026

This means that all attributes used internally in the drivers type check even if __get_attr__ is removed

Cherrypicked from #7845

@jenshnielsen jenshnielsen requested a review from a team as a code owner March 6, 2026 09:21
@jenshnielsen jenshnielsen changed the title Rigol drivers avoid internal dependency on dynamic attributes Rigol + R&S drivers avoid internal dependency on dynamic attributes Mar 6, 2026
@jenshnielsen jenshnielsen enabled auto-merge March 6, 2026 09:25
@codecov
Copy link

codecov bot commented Mar 6, 2026

Codecov Report

❌ Patch coverage is 36.36364% with 28 lines in your changes missing coverage. Please review.
✅ Project coverage is 59.95%. Comparing base (a066b8b) to head (f4df9e3).
⚠️ Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
src/qcodes/instrument_drivers/rohde_schwarz/ZNB.py 7.69% 12 Missing ⚠️
...c/qcodes/instrument_drivers/rigol/Rigol_DS1074Z.py 11.11% 8 Missing ⚠️
...qcodes/instrument_drivers/rohde_schwarz/RTO1000.py 65.00% 7 Missing ⚠️
...rc/qcodes/instrument_drivers/rigol/Rigol_DG4000.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7910      +/-   ##
==========================================
+ Coverage   59.94%   59.95%   +0.01%     
==========================================
  Files         352      352              
  Lines       31937    31949      +12     
==========================================
+ Hits        19145    19156      +11     
- Misses      12792    12793       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant