FIX: CLI Usability Updates#2194
Merged
Merged
Conversation
Several UX/diagnostic improvements to `pyrit_scan` output and scenario execution: - Fix technique progress count: `get_techniques_used()` now aggregates atomic-attack cells by display group, so the progress bar and summary report real technique counts (e.g. 2/14) instead of atomic-attack-cell counts that could exceed the total. - Resolve adversarial chat lazily for simulated-conversation techniques: add `AttackTechniqueFactory.resolve_adversarial_chat()` so matrix-built atomic attacks get the default adversarial target when a seed group carries a simulated conversation, fixing "adversarial_chat is required..." failures. - Include the atomic-attack name in execution error messages for easier triage. - Surface failed attacks and retry pressure in the run summary even on non-failing runs (error type/message per failed attack, total retries), and drop the redundant "Completed" line. - Stream per-attack retry warnings as each result lands during polling, including component role/name and endpoint from the captured RetryEvents. - `--start-server` now prints the log path on success and tails the log on crash/timeout. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 35659834-769b-4088-93cc-bd2603dcc65c
romanlutz
reviewed
Jul 15, 2026
romanlutz
approved these changes
Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A set of CLI usability and diagnostic improvements for scenario runs (
pyrit_scan), making progress reporting honest and errors actionable.Changes
ScenarioResult.get_techniques_used()now aggregates atomic-attack cells by display group, so the progress bar and summary show real technique counts (e.g.2/14) instead of atomic-attack-cell counts that could exceed the total.AttackTechniqueFactory.resolve_adversarial_chat()lazily resolves the default adversarial target when a technique's seed group carries a simulated conversation, fixingadversarial_chat is required when seed_group has a simulated conversation configfailures for techniques likemany_shot_*.Completedline (it always equalledTotal Attacks).RetryEvents.--start-serveroutput. Prints the log path on success and tails the log on crash/timeout.Testing
pre-commitclean (ruff format/check, ty).