[Light Switch] Switch desktop wallpapers with the Light/Dark mode

[YexuanXiao]

I'm not sure how to set the AccentColor and ColorizationColor that is consistent with the Settings App, and the same goes for switching themes. If anyone has a solution, please let me know.

• Closes: One should be able to select themes for lightSwitch (or at least wallpapers) #42436
• Communication: I've discussed this with core contributors already. If the work hasn't been agreed, this work might be rejected
• Tests: Added/updated and all pass
• Localization: All end-user-facing strings can be localized
• Dev docs: Added/updated
• New binaries: Added on the required places
  • JSON for signing for new binaries
  • WXS for installer for new binaries and localization folder
  • YML for CI pipeline for new test projects
  • YML for signed pipeline
• Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

[lei9444]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[Jay-o-Way]

Few things

[YexuanXiao]

Sorry, I meant only BoolToVisibilityConverter is built-in. If you need the negation converter, you should keep that.

I simply tested it and it works.

BoolNegationConverter

The XAML I wrote no longer needs it.

[yeelam-gordon]

🔍 Automated PR Review Summary

Step	Severity	Finding
01-functionality	🔴 high	Problem: SetWallpaperViaIDesktopWallpaper returns when SUCCEEDED(e) for b...
01-functionality	🟡 medium	Problem: IsLightWallpaperValid and IsDarkWallpaperValid update backing fi...
03-performance	🟡 medium	Problem: wallpaper import reads the entire source file into memory (`ReadBuff...
04-accessibility	🟡 medium	Problem: the two wallpaper preview Image controls are introduced without ex...
04-accessibility	🟢 low	Problem: both wallpaper browse buttons resolve to the same user-facing label ...
05-security	🟡 medium	Vulnerability: DeleteFile relies on raw StartsWith(dataPath) without cano...
05-security	🟡 medium	Vulnerability: unvalidated wallpaper style values can reach `default: std::te...
06-localization	🟢 low	Localization quality issue: several newly added short/ambiguous UI strings (f...
09-solid-design	🟡 medium	SOLID violation (SRP + DIP): LightSwitchViewModel now combines presentation...
10-repo-patterns	🟡 medium	Logging pattern deviation: Logger::error is called with an extra argument b...
10-repo-patterns	🟡 medium	Repository logging/error-handling pattern deviation: multiple catch blocks sw...
11-docs-automation	🟢 low	Documentation gap: this PR introduces new user-visible wallpaper configuratio...
12-code-comments	🟡 medium	Comment accuracy issue: `// Prevent attackers from damaging files through spe...

Review generated by pr-review skill. See Generated Files/prReview/44598/ for full details.

[YexuanXiao]

@yeelam-gordon Can you provide more detailed information? The explanation got cut off.