This repository was archived by the owner on Sep 12, 2024. It is now read-only.
Added Exception Logging in InstallModule.py and RemoveModule.py#717
Open
Bhargava-Chary-Chollaty wants to merge 1 commit intomasterfrom
Open
Added Exception Logging in InstallModule.py and RemoveModule.py#717Bhargava-Chary-Chollaty wants to merge 1 commit intomasterfrom
Bhargava-Chary-Chollaty wants to merge 1 commit intomasterfrom
Conversation
jineshcodes
reviewed
Nov 23, 2020
Contributor
jineshcodes
left a comment
jineshcodes
left a comment
There was a problem hiding this comment.
Can you make these same chanegs for python 3 as well?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added exception logging in InstallModule.py and RemoveModule.py
InstallModule.py & RemoveModule.py sometimes fail while executing. This exception is not logged any where and is sometimes difficult to find the reason why the DSC fails. Added try catch and logged the exception message to omsconfig.log file.