Conversation
- Add missing entry. - Regenerate designer code to remove redundant properties. - Fix the namespace the resource designer generates with.
- Use `TryGetValue()` and `Count`/`Length` to improve performance. - Fix typo in test name. - Sort usings.
There was a problem hiding this comment.
Pull Request Overview
This PR addresses various code quality improvements and fixes discovered while working on issue #2459, focusing on performance optimizations, typo corrections, and resource file maintenance.
- Fixes typo in test method name from "RemoveValidatioRule" to "RemoveValidationRule"
- Improves performance by replacing LINQ
.Any()calls with more efficient.Count > 0and.Length != 0checks - Optimizes dictionary operations using
TryGetValue()to avoid multiple key lookups
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| test/Microsoft.OpenApi.Tests/Validations/ValidationRuleSetTests.cs | Fixes typo in test name and replaces .Any() with .Count > 0 and .Length != 0 for performance |
| src/Microsoft.OpenApi/Validations/ValidationRuleSet.cs | Sorts using statements and optimizes dictionary operations with TryGetValue() and .Count > 0 |
| src/Microsoft.OpenApi/Properties/SRResource.resx | Adds missing "ArgumentNull" resource entry |
| src/Microsoft.OpenApi/Microsoft.OpenApi.csproj | Adds CustomToolNamespace for resource file generation |
Files not reviewed (1)
- src/Microsoft.OpenApi/Properties/SRResource.Designer.cs: Language not supported
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes some issues I found while working on #2459.
.resxfile.TryGetValue()andCount/Lengthto improve performance.