fix: Dev v4 to main merge#1010
Open
Dhruvkumar-Microsoft wants to merge 6 commits into
Open
Conversation
… managedIdentityClientId parameter
build: bump idna from 3.11 to 3.16 in uv.lock files
Dhruvkumar-Microsoft
requested review from
Avijit-Microsoft,
Fr4nc3,
Prajwal-Microsoft,
Roopan-Microsoft,
Vinay-Microsoft,
aniaroramsft,
dgp10801,
marktayl1,
nchandhi and
toherman-msft
as code owners
Contributor
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Dhruvkumar-Microsoft
temporarily deployed
to
production
GitHub Actions
Inactive
chore: addressed copilot review comments
Roopan-Microsoft
temporarily deployed
to
production
GitHub Actions
Inactive
Roopan-Microsoft
temporarily deployed
to
production
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request primarily focuses on renaming scripts to replace references to "azure_ai" with "foundry" for improved clarity and consistency, as well as making a small adjustment to error handling in the frontend. The changes help standardize naming conventions and slightly improve error message handling in the UI.
Script renaming and consistency:
infra/scripts/assign_azure_ai_user_role.shtoassign_foundry_user_role.shand updated variable usage to reflect the new naming convention.infra/scripts/cosmosdb_and_ai_user_role_assignment.shtocosmosdb_and_foundry_user_role_assignment.sh, and updated all internal references and log messages from "azure_ai" to "foundry" for consistency.Frontend error handling:
src/App/src/hooks/usePlanWebSocket.tsx, removed the default empty string fallback for theraw_datafield in error messages, so it now always uses the actualfinalMessagevalue.Does this introduce a breaking change?
How to Test
What to Check
Verify that the following are valid
Other Information