fix: prevent plan page infinite loading on refresh before approval#1008
Open
NirajC-Microsoft wants to merge 1 commit into
Open
fix: prevent plan page infinite loading on refresh before approval#1008NirajC-Microsoft wants to merge 1 commit into
NirajC-Microsoft wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request introduces enhancements to the user experience on the
PlanPagecomponent, specifically addressing how the page behaves during reloads and navigation. The changes ensure users are redirected appropriately and warned before leaving the page when a plan is pending approval.User experience improvements:
Technical implementation:
hasHandledReloadflag to ensure the reload redirect logic only executes once per actual page reload.beforeunloadevent based on the approval state of the plan.Does this introduce a breaking change?
How to Test
What to Check
Verify that the following are valid
Other Information