Skip to content

chore: Add tags to prevent SFI W18 Policy violation#428

Open
NirajC-Microsoft wants to merge 3 commits intomainfrom
psl-fix-SFIW18
Open

chore: Add tags to prevent SFI W18 Policy violation#428
NirajC-Microsoft wants to merge 3 commits intomainfrom
psl-fix-SFIW18

Conversation

@NirajC-Microsoft
Copy link
Copy Markdown
Contributor

Purpose

This pull request focuses on improving tag management and making minor template and dependency adjustments in the infrastructure codebase. The most significant change is the merging of resource group tags with custom tags to ensure that all relevant metadata is applied to resources. Additionally, there are updates to the handling of dependencies, template generator metadata, and ARM template expressions for improved clarity and maintainability.

Tag management improvements:

  • Updated the tags property in both infra/main.bicep and infra/main_custom.bicep to merge resourceGroup().tags with allTags, ensuring resources inherit both resource group and custom tags. [1] [2]
  • Changed the ARM template (infra/main.json) to use shallowMerge for combining resource group tags and custom tags, aligning with the Bicep changes.

Template and dependency adjustments:

  • Reordered some dependsOn arrays in infra/main.json to improve deployment sequencing and clarity. [1] [2]
  • Updated ARM template expressions for the scope property to use format instead of resourceId, improving readability and consistency. [1] [2] [3] [4] [5] [6]

Template generator metadata:

Does this introduce a breaking change?

  • Yes
  • No

Golden Path Validation

  • I have tested the primary workflows (the "golden path") to ensure they function correctly without errors.

Deployment Validation

  • I have validated the deployment process successfully and all services are running as expected with this change.

What to Check

Verify that the following are valid

  • ...

Other Information

This comment was marked as resolved.

Copilot AI review requested due to automatic review settings May 8, 2026 13:46

This comment was marked as outdated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants