fix: removed the Unused resource key vault#424
Open
Dhruvkumar-Microsoft wants to merge 1 commit intodevfrom
Open
fix: removed the Unused resource key vault#424Dhruvkumar-Microsoft wants to merge 1 commit intodevfrom
Dhruvkumar-Microsoft wants to merge 1 commit intodevfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes Key Vault provisioning and the associated “export secrets to Key Vault” infrastructure path, simplifying the deployment templates so Key Vault is no longer created/managed by this accelerator.
Changes:
- Removed the Key Vault deployment module and its private DNS zone entry/indexing from
infra/main.bicepandinfra/main_custom.bicep. - Removed the AI Foundry secrets-export-to-Key Vault capability (parameter/type, module invocation, and outputs) from the AI Foundry modules.
- Updated the README security section to remove Key Vault mention; updated generated
infra/main.jsonaccordingly.
Reviewed changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| README.md | Removes Key Vault mention from security guidelines. |
| infra/main.bicep | Drops Key Vault DNS zone/index and removes Key Vault module deployment. |
| infra/main_custom.bicep | Mirrors main template by removing Key Vault DNS zone/index and Key Vault module deployment. |
| infra/main.json | Regenerated ARM template reflecting Key Vault and secrets-export removal. |
| infra/modules/keyVault.bicep | Deleted Key Vault provisioning module. |
| infra/modules/ai-foundry/keyVaultExport.bicep | Deleted module that exported secrets to Key Vault. |
| infra/modules/ai-foundry/dependencies.bicep | Removes secrets export configuration/module; exportedSecrets output now empty. |
| infra/modules/ai-foundry/aifoundry.bicep | Removes secrets export configuration parameter/type wiring to dependencies module. |
| infra/modules/ai-foundry/ai-services.bicep | Removes exported secrets configuration type. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request removes all code related to Key Vault provisioning and secret export from the infrastructure templates. The main impact is that Key Vaults are no longer created or managed by these modules, and secrets are not exported to Key Vaults as part of the deployment. The code is simplified by removing parameters, types, modules, and outputs related to Key Vaults and secret export functionality.
Key Vault removal and related changes:
keyVaultmodule and all associated parameters, variables, and resource dependencies frominfra/main.bicepandinfra/main_custom.bicep, including DNS zone references and index entries. [1] [2] [3] [4] [5] [6]infra/modules/keyVault.bicepfile, removing the definition for provisioning Key Vault resources.infra/modules/ai-foundry/keyVaultExport.bicepfile, removing the logic for exporting secrets to Key Vaults.Secret export functionality removal:
secretsExportConfigurationparameter, type, and related logic frominfra/modules/ai-foundry/aifoundry.bicepandinfra/modules/ai-foundry/dependencies.bicep. This includes removing the module invocation for exporting secrets and the output for exported secrets. [1] [2] [3] [4] [5] [6]secretsExportConfigurationTypetype definition from multiple files. [1] [2] [3]Documentation update:
README.mdto remove mention of Azure Key Vault usage.These changes simplify the infrastructure codebase and remove Key Vault as a managed dependency, so any Key Vault-related functionality must now be handled externally.
Does this introduce a breaking change?
Golden Path Validation
Deployment Validation
What to Check
Verify that the following are valid
Other Information