Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Pull request overview
This PR updates the Python SDK build/install flow so CI can use a pipeline-built foundry-local-core without the SDK installation re-downloading/pinning native dependencies, while keeping the wheel’s dependency metadata intact for end users.
Changes:
- Removed the
skip-native-depsbuild-backend behavior and related documentation fromsdk/python/build_backend.py. - Updated Python CI templates to build the wheel without
-C skip-native-deps=trueand to install the built wheel viapip install --no-deps. - Updated pipeline comments to reflect that dependencies remain in wheel metadata and CI avoids re-downloading via
--no-deps.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| sdk/python/build_backend.py | Removes “skip native deps” patching support; updates docstring to recommend pip install --no-deps in CI. |
| .pipelines/templates/test-python-steps.yml | Builds wheel without skip-native-deps and installs the wheel with --no-deps during tests. |
| .pipelines/templates/build-python-steps.yml | Builds wheel without skip-native-deps and installs the wheel with --no-deps in packaging workflow. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
allows CI to install custom foundry-local-core from pipeline while built package installs foundry-local-core defined in requirements.txt/requirements-winml.txt