Merged
Conversation
The previous logic printed \n when percent >= 100, which caused duplicate lines when the core sends multiple 100% callbacks, and double newlines between EPs. Instead, print \n only when a new EP name appears, and a final \n after the call completes. This is simpler and handles the case where an EP fails before reaching 100%. Updated in both samples (JS, C#) and all 4 SDK READMEs. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts how execution provider (EP) download progress is printed in SDK READMEs and sample apps, aiming to produce cleaner per-EP progress output (single trailing newline) and nicer EP list formatting in samples.
Changes:
- Move newline printing for per-EP download progress out of the progress callback and into a single final print after the download completes (Rust/Python/JS/C# READMEs, JS/C# samples).
- Improve EP list display in samples by adding aligned columns (Name / Registered) and padding EP names for consistent output.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| sdk/rust/README.md | Print a single newline after EP download progress completes (avoids repeated newlines). |
| sdk/python/README.md | Same progress-printing adjustment as Rust (single newline at end). |
| sdk/js/README.md | Same progress-printing adjustment (single newline at end). |
| sdk/cs/README.md | Same progress-printing adjustment (single newline at end). |
| samples/js/native-chat-completions/app.js | Add aligned EP table output and keep progress output aligned; compute shared column width. |
| samples/cs/native-chat-completions/Program.cs | Add aligned EP table output and keep progress output aligned; compute shared column width. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Avoids empty-array crash when no EPs are discovered. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
baijumeswani
approved these changes
Apr 3, 2026
prathikr
pushed a commit
that referenced
this pull request
Apr 3, 2026
Improve EP progress download printing in samples --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
baijumeswani
pushed a commit
that referenced
this pull request
Apr 3, 2026
Improve EP progress download printing in samples --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve EP progress download printing in samples