Skip to content

build(examples): separate browser bundles from CommonJS output - #28095

Open
Jason Hartman (jason-ha) wants to merge 1 commit into
microsoft:mainfrom
jason-ha:examples/build-webpack-to-bundle-folder
Open

build(examples): separate browser bundles from CommonJS output#28095
Jason Hartman (jason-ha) wants to merge 1 commit into
microsoft:mainfrom
jason-ha:examples/build-webpack-to-bundle-folder

Conversation

@jason-ha

Copy link
Copy Markdown
Contributor
  • Reserve dist for CommonJS package output and emit webpack-generated browser artifacts into bundle directories instead.
  • Serve downstream application assets from /app while keeping the webpack-fluid-loader runtime under /code, and translate Fluid UMD manifest paths to the development URL namespace.

Update example webpack configurations, UMD metadata, clean scripts, ignores, and generated-output handling to follow the new convention.

Copilot-Session: 72fc25d5-4cc2-4f20-b0b1-f6eec93165b0

Reserve dist for CommonJS package output and emit webpack-generated browser artifacts into bundle directories instead. Serve downstream application assets from /app while keeping the webpack-fluid-loader runtime under /code, and translate Fluid UMD manifest paths to the development URL namespace.

Update example webpack configurations, UMD metadata, clean scripts, ignores, and generated-output handling to follow the new convention. Ensure webpack-fluid-loader builds both module formats before downstream webpack tasks consume its CommonJS configuration.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 72fc25d5-4cc2-4f20-b0b1-f6eec93165b0
@github-actions

Copy link
Copy Markdown
Contributor

Hi! Thank you for opening this PR. Want me to review it?

Based on the diff (218 lines, 84 files), I've queued these reviewers:

  • Correctness — logic errors, race conditions, lifecycle issues
  • Security — vulnerabilities, secret exposure, injection
  • API Compatibility — breaking changes, release tags, type design
  • Performance — algorithmic regressions, memory leaks
  • Testing — coverage gaps, hollow tests

How this works

  • Adjust the reviewer set by ticking/unticking boxes above. Reviewer toggles alone don't trigger anything.

  • Tick Start review below to dispatch the review fleet.

  • After review finishes, tick Start review again to request another run — it auto-resets after each dispatch.

  • This comment updates as new commits land; your reviewer selections are preserved.

  • Start review

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 83 out of 84 changed files in this pull request and generated no comments.


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@github-actions

Copy link
Copy Markdown
Contributor

Bundle size comparison

Base commit: unresolved
Head commit: 3a3c0cfc9bee4b952870642b54fe99d7128d3ab9

⚠️ Comparison unavailable.

The PR's CI build failed — fix the build and the comment will update once the next run succeeds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: examples Changes that focus on our examples area: repo Repo related work area: tools area: website

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants