build: tag untagged asserts for 3.0.0 release - #28065
Open
Daniel Madrid (dannimad) wants to merge 1 commit into
Open
build: tag untagged asserts for 3.0.0 release#28065Daniel Madrid (dannimad) wants to merge 1 commit into
Daniel Madrid (dannimad) wants to merge 1 commit into
Conversation
Command run: pnpm run policy-check:asserts
github-actions
Bot
added
area: framework
Contributor
There was a problem hiding this comment.
Pull request overview
Tags previously untagged assert() calls with generated short codes as part of 3.0.0 release preparation, ensuring the repository satisfies the assert-tagging policy check and that tagged assertions can be expanded back to human-readable messages in test tooling.
Changes:
- Converted existing string-based asserts to tagged numeric short codes in
@fluidframework/fluid-staticand@fluidframework/tree. - Updated the runtime test short-code expansion map to include the newly generated tags (and remove an unused one).
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/runtime/test-runtime-utils/src/assertionShortCodesMap.ts | Adds new short-code → message entries for the newly tagged asserts (and removes an unused entry). |
| packages/framework/fluid-static/src/treeRootDataObject.ts | Tags an existing assert with 0xd37 for release-time short-code assertion behavior. |
| packages/dds/tree/src/shared-tree/history.ts | Tags an existing assert with 0xd35 to short-code the failure message. |
| packages/dds/tree/src/shared-tree-core/branchCommitCounter.ts | Tags an existing assert with 0xd36 to short-code the failure message. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
|
Hi! Thank you for opening this PR. Want me to review it? Based on the diff (18 lines, 4 files), I've queued these reviewers:
How this works
|
Contributor
Bundle size comparisonBase commit: Notable changesNo bundles changed by ≥ 500 bytes parsed. Per-bundle deltas
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Step 1 of release prep for 3.0.0: tag any untagged asserts before the release, per policy (
flub release preparereported untagged asserts in@fluidframework/treeand@fluidframework/fluid-static).Command run
(which runs
flub generate assertTags --all && npm run format)Merge order
This PR must merge before the version-bump PR (
release-prep/3.0.0/4-bump-<NEXT_VERSION>).Note
This is a preflight PR created ahead of the other release-blocking PRs (#27982, #28037, #28044) merging. It may need to be regenerated/updated once those land, since they could introduce additional untagged asserts.