fix(client-tree): view consistency for post-processed transactions#27673
Open
jason-ha wants to merge 1 commit into
Open
fix(client-tree): view consistency for post-processed transactions#27673jason-ha wants to merge 1 commit into
jason-ha wants to merge 1 commit into
Conversation
When a transaction is post-processed roll back current changes so that the view gets any changes ensuring consistency. Add coverage using a simple test post-processor that eliminates all changes. Additionally optimize inner transaction handling to skip roll back and reapply when post-processor makes no changes.
Contributor
|
Hi! Thank you for opening this PR. Want me to review it? Based on the diff (113 lines, 2 files), I've queued these reviewers:
How this works
|
Contributor
Bundle size comparisonBase commit: Notable changesNo bundles changed by ≥ 500 bytes parsed. Per-bundle deltas
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a transaction is post-processed roll back current changes so that the view gets any changes ensuring consistency.
Add coverage using a simple test post-processor that eliminates all changes.
Additionally optimize inner transaction handling to skip roll back and reapply when post-processor makes no changes.