Skip to content

fix(client-tree): view consistency for post-processed transactions#27673

Open
jason-ha wants to merge 1 commit into
mainfrom
tree/fix-post-processed-transaction-view-consistency
Open

fix(client-tree): view consistency for post-processed transactions#27673
jason-ha wants to merge 1 commit into
mainfrom
tree/fix-post-processed-transaction-view-consistency

Conversation

@jason-ha

Copy link
Copy Markdown
Contributor

When a transaction is post-processed roll back current changes so that the view gets any changes ensuring consistency.

Add coverage using a simple test post-processor that eliminates all changes.

Additionally optimize inner transaction handling to skip roll back and reapply when post-processor makes no changes.

When a transaction is post-processed roll back current changes
so that the view gets any changes ensuring consistency.

Add coverage using a simple test post-processor that eliminates
all changes.

Additionally optimize inner transaction handling to skip roll
back and reapply when post-processor makes no changes.
@jason-ha jason-ha requested a review from a team as a code owner July 10, 2026 18:29
Copilot AI review requested due to automatic review settings July 10, 2026 18:29
@github-actions

Copy link
Copy Markdown
Contributor

Hi! Thank you for opening this PR. Want me to review it?

Based on the diff (113 lines, 2 files), I've queued these reviewers:

  • Correctness — logic errors, race conditions, lifecycle issues
  • Security — vulnerabilities, secret exposure, injection
  • API Compatibility — breaking changes, release tags, type design
  • Performance — algorithmic regressions, memory leaks
  • Testing — coverage gaps, hollow tests

How this works

  • Adjust the reviewer set by ticking/unticking boxes above. Reviewer toggles alone don't trigger anything.

  • Tick Start review below to dispatch the review fleet.

  • After review finishes, tick Start review again to request another run — it auto-resets after each dispatch.

  • This comment updates as new commits land; your reviewer selections are preserved.

  • Start review

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

@github-actions

Copy link
Copy Markdown
Contributor

Bundle size comparison

Base commit: 418178c6e154f45d7f07fae564470284ee6a1270
Head commit: daf5f39bd4bf806ff4d46bea14e281a6099dfa29

Notable changes

No bundles changed by ≥ 500 bytes parsed.

Per-bundle deltas

@fluid-example/bundle-size-tests

  • azureClient.js: parsed 619098 → 619154 (+56), gzip 164828 → 164875 (+47)
  • odspClient.js: parsed 591824 → 591880 (+56), gzip 158938 → 158983 (+45)
  • aqueduct.js: parsed 525587 → 525622 (+35), gzip 140703 → 140735 (+32)
  • fluidFramework.js: parsed 392807 → 392880 (+73), gzip 111526 → 111558 (+32)
  • sharedTree.js: parsed 382194 → 382260 (+66), gzip 108914 → 108939 (+25)
  • containerRuntime.js: parsed 303937 → 303951 (+14), gzip 83200 → 83207 (+7)
  • sharedString.js: parsed 175984 → 175991 (+7), gzip 49445 → 49453 (+8)
  • experimentalSharedTree.js: parsed 160798 → 160798 (0), gzip 45804 → 45804 (0)
  • matrix.js: parsed 159845 → 159852 (+7), gzip 45411 → 45419 (+8)
  • loader.js: parsed 145256 → 145270 (+14), gzip 39063 → 39077 (+14)
  • odspDriver.js: parsed 104329 → 104350 (+21), gzip 32625 → 32635 (+10)
  • directory.js: parsed 66616 → 66623 (+7), gzip 18532 → 18541 (+9)
  • 748.js: parsed 58793 → 58793 (0), gzip 17827 → 17827 (0)
  • map.js: parsed 46709 → 46716 (+7), gzip 14310 → 14318 (+8)
  • odspPrefetchSnapshot.js: parsed 45642 → 45656 (+14), gzip 15277 → 15285 (+8)
  • 985.js: parsed 44491 → 44491 (0), gzip 13726 → 13726 (0)
  • summarizerDelayLoadedModule.js: parsed 30749 → 30749 (0), gzip 7753 → 7753 (0)
  • socketModule.js: parsed 26476 → 26483 (+7), gzip 7887 → 7895 (+8)
  • createNewModule.js: parsed 12480 → 12480 (0), gzip 4786 → 4786 (0)
  • summaryModule.js: parsed 3797 → 3797 (0), gzip 1860 → 1860 (0)
  • connectionState.js: parsed 724 → 724 (0), gzip 429 → 429 (0)
  • sharedTreeAttributes.js: parsed 666 → 673 (+7), gzip 432 → 442 (+10)
  • debugAssert.js: parsed 429 → 429 (0), gzip 299 → 299 (0)
  • FluidFramework-HashFallback.js: parsed 422 → 422 (0), gzip 316 → 316 (0)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants