Skip to content

Minor CMake code review#300

Open
walbourn wants to merge 3 commits intomainfrom
cmakecr
Open

Minor CMake code review#300
walbourn wants to merge 3 commits intomainfrom
cmakecr

Conversation

@walbourn
Copy link
Copy Markdown
Member

@walbourn walbourn commented May 6, 2026

  • CMake 3.21+ allows removal of JoinPaths.cmake helper.
  • Added download failure message to BUILD_SHMATH on non-Win32 targets
  • Added CMP0162 for proper UseDebugLibraries behavior with VS generators
  • In CMake 4.1, the VS Generator no longer adds /Zc:forScope /Zc:inline /Zc:wchar_t to compiler unless listed in the Cmake--only impacts SHMath feature in any case

@walbourn walbourn self-assigned this May 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant