Fix: sys.exit(1) runs unconditionally due to indentation bug#455
Open
Jah-yee wants to merge 1 commit intomicrosoft:mainfrom
Open
Fix: sys.exit(1) runs unconditionally due to indentation bug#455Jah-yee wants to merge 1 commit intomicrosoft:mainfrom
Jah-yee wants to merge 1 commit intomicrosoft:mainfrom
Conversation
The sys.exit(1) was at the same indentation level as the try block, causing it to run unconditionally after subprocess completes - even when the command succeeds. This fix moves sys.exit(1) inside the except block. Affected files: - setup_env.py (line ~110) - utils/e2e_benchmark.py (line ~23)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
sys.exit(1)was at the same indentation level as thetryblock, causing it to run unconditionally after subprocess completes - even when the command succeeds. This fix movessys.exit(1)inside theexceptblock.Bug Details
In the
run_commandfunction, whenlog_stepisNone(theelsebranch), thesys.exit(1)was placed outside theexceptblock:The fix properly indents
sys.exit(1)to be inside theexceptblock.Affected Files
setup_env.py(line ~110)utils/e2e_benchmark.py(line ~23)Related Issue
This PR addresses issue #447