Fix command wrappers exiting after successful runs#454
Open
ishitadatta wants to merge 1 commit intomicrosoft:mainfrom
Open
Fix command wrappers exiting after successful runs#454ishitadatta wants to merge 1 commit intomicrosoft:mainfrom
ishitadatta wants to merge 1 commit intomicrosoft:mainfrom
Conversation
Author
|
@microsoft-github-policy-service agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
setup_env.pyandutils/e2e_benchmark.pyWhy this matters
Both helpers currently call
sys.exit(1)after a successfulsubprocess.run(...)whenlog_stepis not provided. In practice this makes the benchmark helper report failure even when the benchmark itself succeeds, and it leaves the setup helper vulnerable to the same control-flow bug on any future no-log-step call site.This change keeps the existing failure behavior, but stops the scripts from exiting with an error after successful runs.
Validation
python3 -m py_compile setup_env.py utils/e2e_benchmark.py tests/test_command_wrappers.pysys.exit(1)on successful subprocess executionpytestcould not be run in this environment because it is not installed here