Skip to content

Fix const-correctness error in ggml_vec_dot_i2_i8_s_Nx1 #451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Jah-yee wants to merge 3 commits into
base: main
Choose a base branch
from
+4 −4
Open

Fix const-correctness error in ggml_vec_dot_i2_i8_s_Nx1 #451

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dc3daed
fix: update llama.cpp submodule with chrono fix
Jah-yee Mar 13, 2026
2484189
Fix: sys.exit(1) runs unconditionally due to indentation bug
Mar 13, 2026
77bb5e9
Fix const-correctness error in ggml_vec_dot_i2_i8_s_Nx1
Jah-yee Mar 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion 3rdparty/llama.cpp
Open in desktop
Submodule llama.cpp updated from 1f86f0 to 0e7e4f
2 changes: 1 addition & 1 deletion setup_env.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ def run_command(command, shell=False, log_step=None):
subprocess.run(command, shell=shell, check=True)
except subprocess.CalledProcessError as e:
logging.error(f"Error occurred while running command: {e}")
sys.exit(1)
sys.exit(1)

def prepare_model():
_, arch = system_info()
Expand Down
2 changes: 1 addition & 1 deletion src/ggml-bitnet-mad.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -808,7 +808,7 @@ void ggml_vec_dot_i2_i8_s_Nx1(int n, float * s, size_t bs, const void * vx, size
accu[iy] = _mm256_setzero_si256();
}

int8_t * y_col = y + col * by;
const int8_t * y_col = y + col * by;

for (int i = 0; i < group32_num; i++) {
const uint8_t *px = x + i * 1024;
Expand Down
2 changes: 1 addition & 1 deletion utils/e2e_benchmark.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ def run_command(command, shell=False, log_step=None):
subprocess.run(command, shell=shell, check=True)
except subprocess.CalledProcessError as e:
logging.error(f"Error occurred while running command: {e}")
sys.exit(1)
sys.exit(1)

def run_benchmark():
build_dir = os.path.join(os.path.dirname(os.path.dirname(os.path.abspath(__file__))), "build")
Expand Down