[Shopify] Store tax lines linked to order shipping charges

[onbuyuka]

Summary

Shopify shipping GraphQL queries already retrieve shippingLines.taxLines (channelLiable, title, rate, ratePercentage, priceSet), but the shipping import did not persist them. Shipping tax details and Channel Liable status were therefore only available in the raw Retrieved Shopify Data, not as structured records, and could not be viewed from the Shipping Costs page.

This change imports each shipping line's tax lines into the existing Shpfy Order Tax Line table, linked to the shipping charge via Parent Id = Shopify Shipping Line Id (consistent with how header and product-line tax lines are stored), and exposes them from the Shipping Costs page.

Changes

• ShpfyShippingCharges.Codeunit – parse and persist each shipping line's tax lines (title, rate, rate %, shop amount, presentment amount, Channel Liable), using delete-then-recreate so reimport produces no duplicates or stale rows.
• ShpfyOrderShippingCharges.Table – OnDelete now removes the linked tax lines (cleanup when a shipping line is removed on reimport).
• ShpfyOrderTaxLine.Table – currency-code AutoFormat lookups resolve via the shipping charge as well as order line/header.
• ShpfyOrderShippingCharges.Page – new Tax Lines action (opens the existing tax-lines page filtered to the selected shipping charge); migrated the page to the modern area(Promoted) model.
• ShpfyOrderTaxLines.Page – presentment-currency column visibility resolves via the shipping charge.

The GraphQL query files already retrieved taxLines, so no query change was needed.

Test plan

Added tests in ShpfyShippingChargesTest covering:

• channelLiable = true, false, null, and missing (defaults to false)
• all field values preserved (title, rate, rate %, shop/presentment amounts)
• multiple shipping lines keep their tax lines separated
• reimport replaces tax lines without duplicates or stale rows
• removing a shipping line on reimport deletes its shipping charge and tax lines

Fixes AB#642379

[github-actions]

$\textbf{🟡\ Medium\ Severity\ —\ Agent} \quad \color{gray}{\texttt{\small Iteration\ 1}}$

OrderCurrencyCode() and OrderPresentmentCurrencyCode() on "Shpfy Order Tax Line" (used as the AutoFormatExpression for the Amount and Presentment Amount fields) were extended in this PR with an else-branch that resolves the order via "Shpfy Order Shipping Charges" when "Parent Id" is not an order line id, but they stop there.

Order-level tax lines (added via AddTaxLines(OrderHeader."Shopify Order Id", ...) in ShpfyImportOrder.Codeunit.al, where "Parent Id" equals the Shopify Order Id directly) still fall through both branches and return a blank currency code, so Amount/Presentment Amount render without currency formatting for those rows. The sibling logic this PR also touched, ShpfyOrderTaxLines.Page.al's SetShowPresentmentCurrencyVisibility(), was given a third fallback (if not OrderHeader.Get(Rec."Parent Id") then exit) for exactly this case, so the page correctly decides Presentment Amount visibility for order-level rows while the table's own currency-code resolution used to format that same field does not.

Recommendation:

• add the same third fallback (OrderHeader.Get("Parent Id")) to both OrderCurrencyCode() and OrderPresentmentCurrencyCode() so order-level tax lines get correctly formatted amounts, consistent with the page trigger.

Line mapping was unavailable, so this was posted as an issue comment.

_{👍 useful · ❤️ especially valuable · 👎 wrong - reply with why}

[github-actions]

Copilot PR Review

Iteration 3 · Outcome: completed

Knowledge source: https://github.com/microsoft/BCQuality@186d8a131465475c79244d994acb872cd5c0d4bf

Findings by domain

Findings split into Knowledge-backed (cite a BCQuality article) and Agent (the agent's own judgement, no matching BCQuality rule).

Domain	Findings	Knowledge-backed	Agent	Inline	Fallback
Agent	1	0	1	1	0
Performance	1	1	0	1	0
Testing	1	1	0	1	0

Totals: 2 knowledge-backed · 1 agent findings.

Orchestrator pre-filter (2 file(s) excluded)

• layer-disabled (knowledge) : 2 file(s)

_{Findings produced by the AL review agent v1.7.3. Reply 👎 on any inline comment to flag false positives.}

[onbuyuka]

Good catch — applied in c6fee21. OrderCurrencyCode() and OrderPresentmentCurrencyCode() now have the same third fallback (OrderHeader.Get("Parent Id")) as the page's SetShowPresentmentCurrencyVisibility(), so order-level tax lines (Parent Id = Shopify Order Id) get correctly formatted Amount / Presentment Amount.

[github-actions]

$\textbf{🟡\ Medium\ Severity\ —\ Agent} \quad \color{gray}{\texttt{\small Iteration\ 3}}$

The new local procedure AddTaxLines in ShpfyShippingCharges.Codeunit.al (parse tax-line JSON via RecordRef into 'Shpfy Order Tax Line', delete-then-reinsert) is a byte-for-byte duplicate of the pre-existing AddTaxLines in ShpfyImportOrder.Codeunit.al.

Two independent copies of the same mapping logic will drift the next time a tax-line field is added or a mapping bug is fixed in only one of them.

Recommendation:

• extract the shared logic into one internal procedure (e.g. on the 'Shpfy Order Tax Line' table or a shared helper codeunit) and have both call sites use it.

_{👍 useful · ❤️ especially valuable · 👎 wrong - reply with why}

[github-actions]

$\textbf{🟡\ Medium\ Severity\ —\ Performance} \quad \color{gray}{\texttt{\small Iteration\ 3}}$

AddTaxLines deletes prior tax lines with a plain DeleteAll() (RunTrigger = true) while the sibling cleanup in ShpfyOrderShippingCharges.Table.al OnDelete uses DeleteAll(false) for the identical table with no OnDelete trigger to preserve.

Since 'Shpfy Order Tax Line' has no OnDelete trigger, the true form pays per-row trigger-dispatch cost for no behavioral benefit. Use DeleteAll(false) here too for consistency with the established pattern in this same PR.

Suggested change

	OrderTaxLine.DeleteAll();
	OrderTaxLine.DeleteAll(false);

Knowledge:

• microsoft/knowledge/performance/use-deleteall-for-filtered-bulk-deletion.md

_{👍 useful · ❤️ especially valuable · 👎 wrong - reply with why}

[github-actions]

$\textbf{🟡\ Medium\ Severity\ —\ Testing} \quad \color{gray}{\texttt{\small Iteration\ 3}}$

The new tests build their Shopify Order Header fixture with a hand-rolled CreateOrderHeaderForShop (Clear/assign two fields/Insert) and a hand-rolled GetUniqueId counter, instead of the ImportShopifyOrder helper and LibraryRandom-based id generation already used by every other test in this codeunit.

The direct Insert bypasses Validate on 'Shop Code' and any mandatory-field/TableRelation logic the platform enforces in production, so the fixture can silently drift out of sync as the Shpfy Order Header schema evolves, and it diverges from the file's own established fixture convention.

Knowledge:

• microsoft/knowledge/testing/use-library-codeunits-for-test-fixtures.md

_{👍 useful · ❤️ especially valuable · 👎 wrong - reply with why}