[Main]-Bin content Block Movement does not prevent outbound posting for negative adjustments and sales orders

[DeepsShukla]

Workitem Bug 639575: [All-E] Bin content Block Movement does not prevent outbound posting for negative adjustments and sales orders
Fixes AB#639575

[github-actions]

$\textbf{🟠\ High\ Severity\ —\ Data\ Modeling} \quad \color{gray}{\texttt{\small Iteration\ 1}}$

The new Block Movement guard for bin-mandatory (non-directed put-away/pick) locations is added only inside CheckDecreaseBinContent's SourceJnl::" ", SourceJnl::ItemJnl branch (WMSManagement.Codeunit.al ~lines 267-278).

That branch is reused by many item-journal-driven callers (ItemJnlPostBatch, TransferOrderPostTransfer/Shipment/Receipt, InvtDocPostReceipt/Shipment, JobJnlPostLine, PhysInvtOrderPost, AssemblyPost, and now SalesPost via this PR), so those paths are correctly covered. However, the sibling SourceJnl::OutputJnl, SourceJnl::ConsumpJnl branch (line 279) and the SourceJnl::WhseJnl branch (line 288) receive no equivalent check. MfgItemJnlPostLine posts production consumption/output through OutputJnl/ConsumpJnl (SourceJnl 2/3), and WhseActivityPost, WhseJnlRegisterBatch, CreateWarehouseLocation.Report, WhsePostReceipt and WhsePostShipment all post through WhseJnl (SourceJnl 4). None of those flows will honor a Bin Content "Block Movement" of Outbound/All at a bin-mandatory, non-directed-pick location, so production consumption and plain warehouse-journal postings can still decrease a blocked bin even after this fix. This mirrors the referenced knowledge article's principle that a blocked flag must be enforced at every point of use in the referencing code, not just one caller's path.

Knowledge:

• microsoft/knowledge/data-modeling/check-blocked-in-referencing-code-not-in-master.md

Line mapping was unavailable, so this was posted as an issue comment.

_{👍 useful · ❤️ especially valuable · 👎 wrong - reply with why}

[github-actions]

Copilot PR Review

Iteration 1 · Outcome: completed

Knowledge source: https://github.com/microsoft/BCQuality@186d8a131465475c79244d994acb872cd5c0d4bf

Findings by domain

Findings split into Knowledge-backed (cite a BCQuality article) and Agent (the agent's own judgement, no matching BCQuality rule).

Domain	Findings	Knowledge-backed	Agent	Inline	Fallback
Data Modeling	1	1	0	0	1

Totals: 1 knowledge-backed · 0 agent findings.

Orchestrator pre-filter (2 file(s) excluded)

• layer-disabled (knowledge) : 2 file(s)

_{Findings produced by the AL review agent v1.7.3. Reply 👎 on any inline comment to flag false positives.}