removed access internal to edocument mailing

[GOB-Wijaya]

Removed access internal in Codeunit "E-Document Emailing"

Fixes #8566

How I validated this

• I read the full diff and it contains only changes I intended.
• I built the affected app(s) locally with no new analyzer warnings.
• I ran the change in Business Central and confirmed it behaves as expected.
• I added or updated tests for the new behavior, or explained below why none are needed.

[GOB-Wijaya]

@Groenbech96 Can you look at the Pull Request? Thanks in advance!

[github-actions]

$\textbf{🟠\ High\ Severity\ —\ Breaking\ Changes} \quad \color{gray}{\texttt{\small Iteration\ 1}}$

Access = Internal; was removed from codeunit 6188 "E-Document Emailing" with no replacement scoping.

The codeunit's default access is now Public, and its two exposed procedures (SendEDocumentEmail, SetAttachments) carry no explicit access modifier of their own, so they become part of the platform's supported public API surface by default rather than by deliberate design. The commit message ('removed access internal to edocument mailing') gives no rationale, and no procedure was marked internal/local to keep the internal helpers (CreateSourceLists, CreateZipArchiveWithEDocAttachments, etc. are already local and unaffected) out of the contract. Per BCQuality guidance, access should be the narrowest that works, and public should be reserved for entry points intentionally committed to as a stable, maintained API.

Recommendation:

• either keep Access = Internal; if the codeunit is not meant to be a supported external entry point, or, if publicizing SendEDocumentEmail/SetAttachments is intentional, do so explicitly and document/justify the new public contract (and consider whether the widened surface needs a compatibility/versioning note).

Knowledge:

• microsoft/knowledge/breaking-changes/choose-access-modifiers-deliberately.md

Line mapping was unavailable, so this was posted as an issue comment.

_{👍 useful · ❤️ especially valuable · 👎 wrong - reply with why}

[github-actions]

Copilot PR Review

Iteration 1 · Outcome: completed

Knowledge source: https://github.com/microsoft/BCQuality@186d8a131465475c79244d994acb872cd5c0d4bf

Findings by domain

Findings split into Knowledge-backed (cite a BCQuality article) and Agent (the agent's own judgement, no matching BCQuality rule).

Domain	Findings	Knowledge-backed	Agent	Inline	Fallback
Breaking Changes	1	1	0	0	1

Totals: 1 knowledge-backed · 0 agent findings.

Orchestrator pre-filter (2 file(s) excluded)

• layer-disabled (knowledge) : 2 file(s)

_{Findings produced by the AL review agent v1.7.3. Reply 👎 on any inline comment to flag false positives.}