[Master] - 'Greater Than' Withholding Tax Calculation Rule is not applied correctly in Withholding Tax Posting Setup.#9515
Open
DhavalMore88 wants to merge 1 commit into
Conversation
github-actions
Bot
added
AL: Apps (W1)
Contributor
|
Could not find linked issues in the pull request description. Please make sure the pull request description contains a line that contains 'Fixes #' followed by the issue number being fixed. Use that pattern for every issue you want to link. |
Contributor
Copilot PR ReviewIteration 1 · Outcome: completed Knowledge source: https://github.com/microsoft/BCQuality@186d8a131465475c79244d994acb872cd5c0d4bf Orchestrator pre-filter (2 file(s) excluded)
Findings produced by the AL review agent v1.7.3. Reply 👎 on any inline comment to flag false positives. |
v-ankitgoyal
approved these changes
Jul 16, 2026
AndersLarsenMicrosoft
approved these changes
Jul 16, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes withholding tax (WHT) creation/zeroing logic so it correctly respects the configured Wthldg. Tax Calculation Rule (Less than / ≤ / = / > / ≥) when comparing against Wthldg. Tax Min. Inv. Amount, and adds regression tests for the “Greater than” rule behavior on purchase invoices.
Changes:
- Added
ShouldCreateWithholdingTax(...)in Withholding Tax Mgmt. to centralize the rule-aware decision. - Replaced hard-coded minimum-invoice threshold comparisons in purchase/journal subscribers with the new rule-aware helper.
- Added new OnPrem tests to validate WHT entry creation/suppression for the “Greater than” calculation rule.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/Apps/W1/WithholdingTax/app/src/Purchase/Transaction/WithholdingTaxMgmt.Codeunit.al | Adds ShouldCreateWithholdingTax and uses it where minimum-invoice threshold logic previously hard-coded comparisons. |
| src/Apps/W1/WithholdingTax/app/src/Purchase/Transaction/WithholdingTaxJnlSubscriber.Codeunit.al | Updates journal logic to use the centralized rule-aware decision instead of direct amount/min comparisons. |
| src/Apps/W1/WithholdingTax/app/src/Purchase/Transaction/WthldgTaxPurchSubscribers.Codeunit.al | Updates purchase posting logic to use ShouldCreateWithholdingTax before inserting invoice WHT. |
| src/Apps/W1/WithholdingTax/Test/src/ERMWithholdingTaxTestsI.Codeunit.al | Adds new regression tests and supporting helpers for “Greater than” rule scenarios. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+612
to
+615
| procedure ShouldCreateWithholdingTax(InvoiceAmount: Decimal; WithholdingPostingSetup: Record "Withholding Tax Posting Setup"): Boolean | ||
| begin | ||
| exit(not CheckWithholdingCalculationRule(InvoiceAmount, WithholdingPostingSetup)); | ||
| end; |
Comment on lines
670
to
680
| local procedure IsAboveWithholdingMinInvAmount(GenJnlLine: Record "Gen. Journal Line"): Boolean | ||
| var | ||
| WithholdingPostingSetup: Record "Withholding Tax Posting Setup"; | ||
| WithholdingTaxMgmt: Codeunit "Withholding Tax Mgmt."; | ||
| begin | ||
| if not (GenJnlLine."Document Type" in [GenJnlLine."Document Type"::Invoice, GenJnlLine."Document Type"::"Credit Memo"]) then | ||
| exit(true); | ||
|
|
||
| if WithholdingPostingSetup.Get(GenJnlLine."Wthldg. Tax Bus. Post. Group", GenJnlLine."Wthldg. Tax Prod. Post. Group") then | ||
| exit(Abs(GenJnlLine.Amount) >= WithholdingPostingSetup."Wthldg. Tax Min. Inv. Amount"); | ||
| exit(WithholdingTaxMgmt.ShouldCreateWithholdingTax(GenJnlLine.Amount, WithholdingPostingSetup)); | ||
|
|
Comment on lines
+2804
to
+2818
| local procedure VerifyWHTEntryExists(DocumentNo: Code[20]) | ||
| var | ||
| WHTEntry: Record "Withholding Tax Entry"; | ||
| begin | ||
| WHTEntry.SetRange("Document No.", DocumentNo); | ||
| Assert.RecordIsNotEmpty(WHTEntry); | ||
| end; | ||
|
|
||
| local procedure VerifyWHTEntryDoesNotExist(DocumentNo: Code[20]) | ||
| var | ||
| WHTEntry: Record "Withholding Tax Entry"; | ||
| begin | ||
| WHTEntry.SetRange("Document No.", DocumentNo); | ||
| Assert.RecordIsEmpty(WHTEntry); | ||
| end; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug 642326: [master] [All-e]'Greater Than' Withholding Tax Calculation Rule is not applied correctly in Withholding Tax Posting Setup.
AB#642326
Issue: When a Withholding Tax Posting Setup uses a "Wthldg. Tax Calculation Rule" other than "Less than" (e.g. "Greater than", "Greater than or equal to", "Equal to"), the withholding tax was calculated/zeroed incorrectly against the "Wthldg. Tax Min. Inv. Amount". WHT was created (or suppressed) based on the wrong comparison, so amounts that should have been excluded got taxed and vice-versa.
Cause: Multiple threshold checks across Withholding Tax Jnl Subscriber, Withholding Tax Mgmt., and Wthldg Tax Purch. Subscribers hard-coded the comparison as Abs(Amount) < WithholdingPostingSetup."Wthldg. Tax Min. Inv. Amount". This assumed a "Less than" rule and completely ignored the configured "Wthldg. Tax Calculation Rule" enum, so the other rule options (Greater than, etc.) were never honored.
Solution: Added a reusable ShouldCreateWithholdingTax(Amount, WithholdingPostingSetup) procedure in Withholding Tax Mgmt. that returns not CheckWithholdingCalculationRule(...), so the decision respects the actual configured "Wthldg. Tax Calculation Rule" (Less than / ≤ / Equal / Greater than / ≥). Replaced all hard-coded Abs(Amount) < Min Inv. Amount checks in the three transaction codeunits with this rule-aware call, ensuring consistent, correct WHT creation and zeroing for every calculation rule.