Skip to content

[Main]-Interest Document issued with non-taxable VAT does not generate non-taxable VAT entries in the Spanish localization#9514

Open
neeleshsinghal wants to merge 1 commit into
microsoft:mainfrom
neeleshsinghal:bugs/Bug-642269-Interest-Document-issued-non-taxable-VAT-not-generate-non-tax
Open

[Main]-Interest Document issued with non-taxable VAT does not generate non-taxable VAT entries in the Spanish localization#9514
neeleshsinghal wants to merge 1 commit into
microsoft:mainfrom
neeleshsinghal:bugs/Bug-642269-Interest-Document-issued-non-taxable-VAT-not-generate-non-tax

Conversation

@neeleshsinghal

@neeleshsinghal neeleshsinghal commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Workitem :-Bug 642269: [master] [all-e]Interest Document issued with non-taxable VAT does not generate non-taxable VAT entries in the Spanish localization

Fixes AB#642269

@github-actions github-actions Bot added From Fork Pull request is coming from a fork Linked Issue is linked to a Azure Boards work item labels Jul 15, 2026
@github-actions github-actions Bot added this to the Version 29.0 milestone Jul 15, 2026
@neeleshsinghal neeleshsinghal added the Finance GitHub request for Finance area label Jul 15, 2026
@neeleshsinghal neeleshsinghal requested a review from Copilot July 15, 2026 13:50

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes Spanish localization behavior so that issuing a Finance Charge Memo (interest document) can generate No Taxable VAT entries when the interest G/L account is configured with No Taxable VAT. It also adds automated test coverage to validate both the positive and negative scenarios.

Changes:

  • Extend No Taxable Mgt. posting logic to create No Taxable Entries for Finance Charge Memo postings.
  • Add ES localization tests covering issuance of finance charge memos with non-taxable vs taxable interest VAT setups.
  • Add a request page handler to automate “Suggest Fin. Charge Memo Lines” during tests.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/Layers/ES/Tests/Local/NoTaxableDocuments.Codeunit.al Adds two tests and supporting helpers to verify No Taxable Entry creation (or not) when issuing Finance Charge Memos.
src/Layers/ES/BaseApp/Local/Finance/VAT/Calculation/NoTaxableMgt.Codeunit.al Adds Finance Charge Memo handling to the No Taxable Entry creation flow during customer posting.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@neeleshsinghal neeleshsinghal marked this pull request as ready for review July 16, 2026 09:43
@neeleshsinghal neeleshsinghal requested review from a team and v-ankitgoyal July 16, 2026 09:43
@neeleshsinghal neeleshsinghal enabled auto-merge July 16, 2026 09:57
@github-actions

Copy link
Copy Markdown
Contributor

Copilot PR Review

Iteration 1 · Outcome: completed

Knowledge source: https://github.com/microsoft/BCQuality@186d8a131465475c79244d994acb872cd5c0d4bf

Orchestrator pre-filter (2 file(s) excluded)

  • layer-disabled (knowledge) : 2 file(s)

Findings produced by the AL review agent v1.7.3. Reply 👎 on any inline comment to flag false positives.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Finance GitHub request for Finance area From Fork Pull request is coming from a fork Linked Issue is linked to a Azure Boards work item

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants