Skip to content

[Subcontracting] Rename Fields for integration into Italy #8158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ChethanT merged 11 commits into from
May 19, 2026
Merged

[Subcontracting] Rename Fields for integration into Italy #8158

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
1a391ef
Rename Fields for integration into Italy
SPinkow May 8, 2026
b8f585e
Correct Test
SPinkow May 8, 2026
f8c58ee
Add IT to pipeline
SPinkow May 12, 2026
44ffe93
Rename Additional fields
SPinkow May 13, 2026
ed3b379
Additional Renames
SPinkow May 13, 2026
d7fb8fa
Last Rename
SPinkow May 13, 2026
1f63f85
Remove IT from Pipeline (will be added later again)
SPinkow May 13, 2026
26017f8
Merge remote-tracking branch 'upstream/main' into w/pinkow/406123_Ren…
SPinkow May 13, 2026
a2d7b10
Merge remote-tracking branch 'upstream/main' into w/pinkow/406123_Ren…
SPinkow May 15, 2026
b50ce4a
Merge remote-tracking branch 'upstream/main' into w/pinkow/406123_Ren…
SPinkow May 18, 2026
ca71aeb
Use renamed fields
SPinkow May 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...cting/App/src/Process/Codeunits/Extensions/Manufacturing/SubcCalcProdOrderExt.Codeunit.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,8 @@ codeunit 99001517 "Subc. Calc. Prod. Order Ext."

local procedure TransferSubcontractingFieldsBOMComponent(var ProductionBOMLine: Record "Production BOM Line"; var ProdOrderComponent: Record "Prod. Order Component")
begin
ProdOrderComponent."Orig. Location Code" := ProdOrderComponent."Location Code";
ProdOrderComponent."Orig. Bin Code" := ProdOrderComponent."Bin Code";
ProdOrderComponent."Subc. Original Location Code" := ProdOrderComponent."Location Code";
ProdOrderComponent."Subc. Orig. Bin Code" := ProdOrderComponent."Bin Code";
ProdOrderComponent."Subcontracting Type" := ProductionBOMLine."Subcontracting Type";

OnAfterTransferSubcontractingFieldsBOMComponent(ProductionBOMLine, ProdOrderComponent);
Expand Down
4 changes: 2 additions & 2 deletions ...ting/App/src/Process/Codeunits/Extensions/Manufacturing/SubcCarryOutActionExt.Codeunit.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ codeunit 99001523 "Subc. Carry Out Action Ext."
local procedure OnAfterTransferPlanningComp(var PlanningComponent: Record "Planning Component"; var ProdOrderComponent: Record "Prod. Order Component")
begin
ProdOrderComponent."Subcontracting Type" := PlanningComponent."Subcontracting Type";
ProdOrderComponent."Orig. Location Code" := PlanningComponent."Orig. Location Code";
ProdOrderComponent."Orig. Bin Code" := PlanningComponent."Orig. Bin Code";
ProdOrderComponent."Subc. Original Location Code" := PlanningComponent."Orig. Location Code";
ProdOrderComponent."Subc. Orig. Bin Code" := PlanningComponent."Orig. Bin Code";
end;
}
6 changes: 3 additions & 3 deletions ...acting/App/src/Process/Codeunits/Extensions/Manufacturing/SubcPlanningCompExt.Codeunit.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,8 @@ codeunit 99001522 "Subc. Planning Comp. Ext."
local procedure OnAfterTransferFromComponent(var PlanningComponent: Record "Planning Component"; var ProdOrderComp: Record "Prod. Order Component")
begin
PlanningComponent."Subcontracting Type" := ProdOrderComp."Subcontracting Type";
PlanningComponent."Orig. Location Code" := ProdOrderComp."Orig. Location Code";
PlanningComponent."Orig. Bin Code" := ProdOrderComp."Orig. Bin Code";
PlanningComponent."Orig. Location Code" := ProdOrderComp."Subc. Original Location Code";
PlanningComponent."Orig. Bin Code" := ProdOrderComp."Subc. Orig. Bin Code";
end;

[EventSubscriber(ObjectType::Table, Database::"Planning Component", OnAfterValidateEvent, "Location Code", false, false)]
Expand Down Expand Up @@ -62,7 +62,7 @@ codeunit 99001522 "Subc. Planning Comp. Ext."
PlanningRoutingLine.SetRange(Type, PlanningRoutingLine.Type::"Work Center");
if PlanningRoutingLine.FindFirst() then
if SubcontractingManagement.GetSubcontractor(PlanningRoutingLine."No.", Vendor) then
SubcontractingManagement.ChangeLocationOnPlanningComponent(PlanningComponent, Vendor."Subcontr. Location Code", PlanningComponent."Orig. Location Code", PlanningComponent."Orig. Bin Code");
SubcontractingManagement.ChangeLocationOnPlanningComponent(PlanningComponent, Vendor."Subc. Location Code", PlanningComponent."Orig. Location Code", PlanningComponent."Orig. Bin Code");
end else
if xPlanningComponent."Routing Link Code" <> '' then
if PlanningComponent."Orig. Location Code" <> '' then begin
Expand Down
44 changes: 22 additions & 22 deletions ...cting/App/src/Process/Codeunits/Extensions/Manufacturing/SubcProdOrderCompExt.Codeunit.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,9 +75,9 @@ codeunit 99001524 "Subc. Prod. Order Comp. Ext."
if ProdOrderComponent."Subcontracting Type" <> "Subcontracting Type"::Transfer then
exit;

TransferShipmentLine.SetRange("Prod. Order No.", ProdOrderComponent."Prod. Order No.");
TransferShipmentLine.SetRange("Prod. Order Line No.", ProdOrderComponent."Prod. Order Line No.");
TransferShipmentLine.SetRange("Prod. Order Comp. Line No.", ProdOrderComponent."Line No.");
TransferShipmentLine.SetRange("Subc. Prod. Order No.", ProdOrderComponent."Prod. Order No.");
TransferShipmentLine.SetRange("Subc. Prod. Order Line No.", ProdOrderComponent."Prod. Order Line No.");
TransferShipmentLine.SetRange("Subc. Prod. Ord. Comp Line No.", ProdOrderComponent."Line No.");
TransferShipmentLine.SetRange("Item No.", ProdOrderComponent."Item No.");
if not TransferShipmentLine.IsEmpty() then begin
TransferShipmentLine.SetLoadFields(SystemId);
Expand Down Expand Up @@ -146,10 +146,10 @@ codeunit 99001524 "Subc. Prod. Order Comp. Ext."
if ProdOrderComponent."Subcontracting Type" <> "Subcontracting Type"::Transfer then
exit;

TransferLine.SetCurrentKey("Prod. Order No.", "Routing No.", "Routing Reference No.", "Operation No.", "Subcontr. Purch. Order No.");
TransferLine.SetRange("Prod. Order No.", ProdOrderComponent."Prod. Order No.");
TransferLine.SetRange("Prod. Order Line No.", ProdOrderComponent."Prod. Order Line No.");
TransferLine.SetRange("Prod. Order Comp. Line No.", ProdOrderComponent."Line No.");
TransferLine.SetCurrentKey("Subc. Prod. Order No.", "Subc. Routing No.", "Subc. Routing Reference No.", "Subc. Operation No.", "Subc. Purch. Order No.");
TransferLine.SetRange("Subc. Prod. Order No.", ProdOrderComponent."Prod. Order No.");
TransferLine.SetRange("Subc. Prod. Order Line No.", ProdOrderComponent."Prod. Order Line No.");
TransferLine.SetRange("Subc. Prod. Ord. Comp Line No.", ProdOrderComponent."Line No.");
TransferLine.SetRange("Item No.", ProdOrderComponent."Item No.");
TransferLine.SetLoadFields(SystemId);
if TransferLine.FindFirst() then
Expand Down Expand Up @@ -178,12 +178,12 @@ codeunit 99001524 "Subc. Prod. Order Comp. Ext."

GetProdOrderRtngLineFromProdOrderComp(ProdOrderRoutingLine, ProdOrderComponent);

TransferLine.SetCurrentKey("Prod. Order No.", "Prod. Order Line No.", "Routing Reference No.", "Routing No.", "Operation No.");
TransferLine.SetRange("Prod. Order No.", ProdOrderLine."Prod. Order No.");
TransferLine.SetRange("Prod. Order Line No.", ProdOrderLine."Line No.");
TransferLine.SetRange("Routing Reference No.", ProdOrderLine."Routing Reference No.");
TransferLine.SetRange("Routing No.", ProdOrderRoutingLine."Routing No.");
TransferLine.SetRange("Operation No.", ProdOrderRoutingLine."Operation No.");
TransferLine.SetCurrentKey("Subc. Prod. Order No.", "Subc. Prod. Order Line No.", "Subc. Routing Reference No.", "Subc. Routing No.", "Subc. Operation No.");
TransferLine.SetRange("Subc. Prod. Order No.", ProdOrderLine."Prod. Order No.");
TransferLine.SetRange("Subc. Prod. Order Line No.", ProdOrderLine."Line No.");
TransferLine.SetRange("Subc. Routing Reference No.", ProdOrderLine."Routing Reference No.");
TransferLine.SetRange("Subc. Routing No.", ProdOrderRoutingLine."Routing No.");
TransferLine.SetRange("Subc. Operation No.", ProdOrderRoutingLine."Operation No.");
TransferLine.SetRange("Item No.", ProdOrderComponent."Item No.");
TransferLine.SetRange("Variant Code", ProdOrderComponent."Variant Code");
if TransferLine.IsEmpty() then
Expand Down Expand Up @@ -274,16 +274,16 @@ codeunit 99001524 "Subc. Prod. Order Comp. Ext."
ProdOrderComponent."Due Time" := ProdOrderRoutingLine."Starting Time";
if (ProdOrderRoutingLine.Type = ProdOrderRoutingLine.Type::"Work Center") then
if SubcontractingManagement.GetSubcontractor(ProdOrderRoutingLine."No.", Vendor) then
SubcontractingManagement.ChangeLocationOnProdOrderComponent(ProdOrderComponent, Vendor."Subcontr. Location Code", ProdOrderComponent."Orig. Location Code", ProdOrderComponent."Orig. Bin Code");
SubcontractingManagement.ChangeLocationOnProdOrderComponent(ProdOrderComponent, Vendor."Subc. Location Code", ProdOrderComponent."Subc. Original Location Code", ProdOrderComponent."Subc. Orig. Bin Code");
end;
end else
if xProdOrderComponent."Routing Link Code" <> '' then
if ProdOrderComponent."Orig. Location Code" <> '' then begin
ProdOrderComponent.Validate("Location Code", ProdOrderComponent."Orig. Location Code");
ProdOrderComponent."Orig. Location Code" := '';
if ProdOrderComponent."Orig. Bin Code" <> '' then begin
ProdOrderComponent.Validate("Bin Code", ProdOrderComponent."Orig. Bin Code");
ProdOrderComponent."Orig. Bin Code" := '';
if ProdOrderComponent."Subc. Original Location Code" <> '' then begin
ProdOrderComponent.Validate("Location Code", ProdOrderComponent."Subc. Original Location Code");
ProdOrderComponent."Subc. Original Location Code" := '';
if ProdOrderComponent."Subc. Orig. Bin Code" <> '' then begin
ProdOrderComponent.Validate("Bin Code", ProdOrderComponent."Subc. Orig. Bin Code");
ProdOrderComponent."Subc. Orig. Bin Code" := '';
end;
end else begin
PlanningGetParameters.AtSKU(
Expand All @@ -298,13 +298,13 @@ codeunit 99001524 "Subc. Prod. Order Comp. Ext."
local procedure SetOriginalBinCode(var ProdOrderComponent: Record "Prod. Order Component"; var xProdOrderComponent: Record "Prod. Order Component")
begin
if ProdOrderComponent."Bin Code" <> xProdOrderComponent."Bin Code" then
ProdOrderComponent."Orig. Bin Code" := xProdOrderComponent."Bin Code";
ProdOrderComponent."Subc. Orig. Bin Code" := xProdOrderComponent."Bin Code";
end;

local procedure SetOriginalLocationCode(var ProdOrderComponent: Record "Prod. Order Component"; var xProdOrderComponent: Record "Prod. Order Component")
begin
if (ProdOrderComponent."Location Code" <> xProdOrderComponent."Location Code") then
ProdOrderComponent."Orig. Location Code" := xProdOrderComponent."Location Code";
ProdOrderComponent."Subc. Original Location Code" := xProdOrderComponent."Location Code";
end;

local procedure CheckExistingDocumentsForSubcontracting(var ProdOrderComponent: Record "Prod. Order Component"; var xProdOrderComponent: Record "Prod. Order Component"; CurrFieldNo: Integer)
Expand Down
6 changes: 3 additions & 3 deletions ...Subcontracting/App/src/Process/Codeunits/Extensions/Purchase/SubcPurchPostExt.Codeunit.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,8 @@ codeunit 99001535 "Subc. Purch. Post Ext"
[EventSubscriber(ObjectType::Codeunit, Codeunit::"Mfg. Purch.-Post", OnAfterPostItemJnlLineCopyProdOrder, '', false, false)]
local procedure MfgPurchPostOnAfterPostItemJnlLineCopyProdOrder(var ItemJnlLine: Record "Item Journal Line"; PurchLine: Record "Purchase Line")
begin
ItemJnlLine."Subcontr. Purch. Order No." := PurchLine."Document No.";
ItemJnlLine."Subcontr. PO Line No." := PurchLine."Line No.";
ItemJnlLine."Subc. Purch. Order No." := PurchLine."Document No.";
ItemJnlLine."Subc. Purch. Order Line No." := PurchLine."Line No.";
ItemJnlLine."Subc. Operation No." := PurchLine."Operation No.";
end;

Expand Down Expand Up @@ -96,7 +96,7 @@ codeunit 99001535 "Subc. Purch. Post Ext"
Item.SetLoadFields("Inventory Posting Group");
Item.Get(ItemJournalLine."Item No.");
ItemJournalLine."Inventory Posting Group" := Item."Inventory Posting Group";
ItemJournalLine."Item Charge Sub. Assign." := true;
ItemJournalLine."Subc. Item Charge Assign." := true;
end;

[EventSubscriber(ObjectType::Codeunit, Codeunit::"Purch.-Post", OnPostItemJnlLineOnAfterPostItemJnlLineJobConsumption, '', false, false)]
Expand Down
2 changes: 1 addition & 1 deletion ...ntracting/App/src/Process/Codeunits/Extensions/Purchase/SubcPurchaseHeaderExt.Codeunit.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ codeunit 99001533 "Subc. Purchase Header Ext"
[EventSubscriber(ObjectType::Table, Database::"Purchase Header", OnAfterCopyBuyFromVendorFieldsFromVendor, '', false, false)]
local procedure OnAfterCopyBuyFromVendorFieldsFromVendor(var PurchaseHeader: Record "Purchase Header"; Vendor: Record Vendor; xPurchaseHeader: Record "Purchase Header")
begin
PurchaseHeader."Subc. Location Code" := Vendor."Subcontr. Location Code";
PurchaseHeader."Subc. Location Code" := Vendor."Subc. Location Code";
end;

[EventSubscriber(ObjectType::Table, Database::"Purchase Header", OnAfterValidateEvent, "Buy-from Vendor No.", false, false)]
Expand Down
18 changes: 9 additions & 9 deletions ...W1/Subcontracting/App/src/Process/Codeunits/Extensions/SubcItemJnlPostLineExt.Codeunit.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,23 +67,23 @@ codeunit 99001515 "Subc. ItemJnlPostLine Ext"

local procedure UpdateNewItemLedgerEntry(var NewItemLedgerEntry: Record "Item Ledger Entry"; var ItemJournalLine: Record "Item Journal Line")
begin
NewItemLedgerEntry."Prod. Order No." := ItemJournalLine."Prod. Order No.";
NewItemLedgerEntry."Prod. Order Line No." := ItemJournalLine."Prod. Order Line No.";
NewItemLedgerEntry."Subcontr. Purch. Order No." := ItemJournalLine."Subcontr. Purch. Order No.";
NewItemLedgerEntry."Subcontr. PO Line No." := ItemJournalLine."Subcontr. PO Line No.";
NewItemLedgerEntry."Operation No." := ItemJournalLine."Subc. Operation No.";
NewItemLedgerEntry."Subc. Prod. Order No." := ItemJournalLine."Subc. Prod. Order No.";
NewItemLedgerEntry."Subc. Prod. Order Line No." := ItemJournalLine."Subc. Prod. Order Line No.";
NewItemLedgerEntry."Subc. Purch. Order No." := ItemJournalLine."Subc. Purch. Order No.";
NewItemLedgerEntry."Subc. Purch. Order Line No." := ItemJournalLine."Subc. Purch. Order Line No.";
NewItemLedgerEntry."Subc. Operation No." := ItemJournalLine."Subc. Operation No.";
end;

local procedure UpdateCapLedgerEntry(var CapacityLedgerEntry: Record "Capacity Ledger Entry"; var ItemJournalLine: Record "Item Journal Line")
begin
CapacityLedgerEntry."Subcontractor No." := ItemJournalLine."Source No.";
CapacityLedgerEntry."Subcontr. Purch. Order No." := ItemJournalLine."Subcontr. Purch. Order No.";
CapacityLedgerEntry."Subcontr. PO Line No." := ItemJournalLine."Subcontr. PO Line No.";
CapacityLedgerEntry."Subc. Subcontractor No." := ItemJournalLine."Source No.";
CapacityLedgerEntry."Subc. Purch. Order No." := ItemJournalLine."Subc. Purch. Order No.";
CapacityLedgerEntry."Subc. Purch. Order Line No." := ItemJournalLine."Subc. Purch. Order Line No.";
end;

local procedure ClearInvoicedQuantityForItemChargeSubAssign(var ValueEntry: Record "Value Entry"; var ItemJournalLine: Record "Item Journal Line")
begin
if ItemJournalLine."Item Charge Sub. Assign." and (ValueEntry."Entry Type" = "Cost Entry Type"::"Direct Cost") then
if ItemJournalLine."Subc. Item Charge Assign." and (ValueEntry."Entry Type" = "Cost Entry Type"::"Direct Cost") then
ValueEntry."Invoiced Quantity" := 0;
end;
}
18 changes: 9 additions & 9 deletions ...cting/App/src/Process/Codeunits/Extensions/Transfer/SubcDirectTransferLineExt.Codeunit.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,14 +11,14 @@ codeunit 99001548 "Subc. DirectTransferLine Ext."
[EventSubscriber(ObjectType::Table, Database::"Direct Trans. Line", OnAfterCopyFromTransferLine, '', false, false)]
local procedure OnAfterCopyFromTransferLine_T5745(var DirectTransLine: Record "Direct Trans. Line"; TransferLine: Record "Transfer Line")
begin
DirectTransLine."Subcontr. Purch. Order No." := TransferLine."Subcontr. Purch. Order No.";
DirectTransLine."Subcontr. PO Line No." := TransferLine."Subcontr. PO Line No.";
DirectTransLine."Prod. Order No." := TransferLine."Prod. Order No.";
DirectTransLine."Prod. Order Line No." := TransferLine."Prod. Order Line No.";
DirectTransLine."Prod. Order Comp. Line No." := TransferLine."Prod. Order Comp. Line No.";
DirectTransLine."Routing No." := TransferLine."Routing No.";
DirectTransLine."Routing Reference No." := TransferLine."Routing Reference No.";
DirectTransLine."Work Center No." := TransferLine."Work Center No.";
DirectTransLine."Operation No." := TransferLine."Operation No.";
DirectTransLine."Subcontr. Purch. Order No." := TransferLine."Subc. Purch. Order No.";
DirectTransLine."Subcontr. PO Line No." := TransferLine."Subc. Purch. Order Line No.";
DirectTransLine."Prod. Order No." := TransferLine."Subc. Prod. Order No.";
DirectTransLine."Prod. Order Line No." := TransferLine."Subc. Prod. Order Line No.";
DirectTransLine."Prod. Order Comp. Line No." := TransferLine."Subc. Prod. Ord. Comp Line No.";
DirectTransLine."Routing No." := TransferLine."Subc. Routing No.";
DirectTransLine."Routing Reference No." := TransferLine."Subc. Routing Reference No.";
DirectTransLine."Work Center No." := TransferLine."Subc. Work Center No.";
DirectTransLine."Operation No." := TransferLine."Subc. Operation No.";
end;
}
Loading
Loading