Skip to content

Fix AA0073: Add Temp prefix to temporary Record variables#7287

Open
SBalslev wants to merge 1 commit intomainfrom
private/sbalslev/fix-AA0073-temp-prefix
Open

Fix AA0073: Add Temp prefix to temporary Record variables#7287
SBalslev wants to merge 1 commit intomainfrom
private/sbalslev/fix-AA0073-temp-prefix

Conversation

@SBalslev
Copy link
Contributor

@SBalslev SBalslev commented Mar 19, 2026

Summary

Fixes 94 CodeCop AA0073 violations across 47 files in System Application.

Rule AA0073: The name of temporary variable must be prefixed with Temp.

These variables reference tables defined with TableType = Temporary, which makes every Record variable of that type inherently temporary — the Temp prefix is required by naming convention.

Changes

All changes are mechanical renames of local Record variables by adding a Temp prefix to the variable name. All usages within each procedure scope are updated accordingly.

Examples:

  • EmailAccounts to TempEmailAccounts
  • DefaultEmailAccount to TempDefaultEmailAccount
  • AppSourceProductTemp to TempAppSourceProduct (moved prefix to front)

Scope

  • 47 files in src/System Application/App/
  • 362 lines changed (pure renames — equal insertions and deletions)
  • Affected modules: Email, Security Groups, Agent, Performance Profiler, Permission Sets, User Settings, SharePoint, Word Templates, MCP, Barcode, Regex, and others.

Fixes AB#626125

@SBalslev SBalslev requested review from a team as code owners March 19, 2026 15:24
JesperSchulz
JesperSchulz previously approved these changes Mar 19, 2026
Rename 94 temporary Record variables across 47 files to comply with
CodeCop rule AA0073 (temporary variable names must be prefixed with Temp).

All affected variables reference tables defined with TableType = Temporary.
The rename is purely cosmetic — no behavioral changes.

Special cases:
- AppSourceProductTemp -> TempAppSourceProduct (prefix instead of suffix)
- AgentSetupBuffer local UserSettings -> TempFetchedUserSettings (avoid
  shadowing existing global TempUserSettings)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@SBalslev SBalslev force-pushed the private/sbalslev/fix-AA0073-temp-prefix branch from 22514f1 to 82e8c01 Compare March 19, 2026 17:19
@github-actions github-actions bot added this to the Version 29.0 milestone Mar 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants