-
Notifications
You must be signed in to change notification settings - Fork 323
Fix e-document draft UX: show error factbox and allow finalize from Ready for Draft state #6365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…eady for Draft state Co-authored-by: Groenbech96 <17690329+Groenbech96@users.noreply.github.com>
… draft Co-authored-by: Groenbech96 <17690329+Groenbech96@users.noreply.github.com>
|
@copilot Dont add the extra reprocessing, as the underlying system will do that already. Please add a test that verifies that going from ready for draft, clicking finalize action, will indeed behave as expected. |
…for Draft state Co-authored-by: Groenbech96 <17690329+Groenbech96@users.noreply.github.com>
... Removed the extra reprocessing logic and added the test |
…ot/improve-document-draft-validation
|
@copilot Build: ./src/Apps/W1/EDocument/Test/src/Processing/EDocProcessTest.Codeunit.al#L386 |
…nce check Co-authored-by: Groenbech96 <17690329+Groenbech96@users.noreply.github.com>
Fixed by using |
Summary of Changes
This PR fixes UX issues in the e-document draft page (Page 6181 "E-Document Purchase Draft"):
Changes:
Error Messages FactBox visibility (line 275)
Visible = false;toVisible = HasErrorsOrWarnings;Finalize Action visibility (line 527)
Test added (
EDocProcessTest.Codeunit.al)FinishDraftFromReadyForDraftStateSucceedstest💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.
Fixes AB#620054