Skip to content

Split the slowest smoke test to reduce PR check time #4598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xiang17 wants to merge 4 commits into
base: main
Choose a base branch
from
+37 −18
Open

Split the slowest smoke test to reduce PR check time #4598

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9bf41d8
Split the longest smoke test for more parallel
xiang17 Jan 24, 2026
314a866
./gradlew spotlessApply
xiang17 Jan 24, 2026
1e23202
Add comment
xiang17 Feb 28, 2026
4c82d14
./gradlew spotlessApply
xiang17 Feb 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 37 additions & 0 deletions .../com/microsoft/applicationinsights/smoketest/CoreAndFilter3xUsingOld3xAgentSplitTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,37 @@
// Copyright (c) Microsoft Corporation. All rights reserved.
// Licensed under the MIT License.

package com.microsoft.applicationinsights.smoketest;

import static com.microsoft.applicationinsights.smoketest.EnvironmentValue.TOMCAT_8_JAVA_17;
import static com.microsoft.applicationinsights.smoketest.EnvironmentValue.TOMCAT_8_JAVA_17_OPENJ9;
import static com.microsoft.applicationinsights.smoketest.EnvironmentValue.WILDFLY_13_JAVA_8;
import static com.microsoft.applicationinsights.smoketest.EnvironmentValue.WILDFLY_13_JAVA_8_OPENJ9;

/**
* Container for additional environment variants of {@link CoreAndFilter3xUsingOld3xAgentTest}.
*
* <p>This class is split out so build/CI can run the "core" environment matrix from {@link
* CoreAndFilter3xUsingOld3xAgentTest} (e.g. via Gradle {@code --tests
* "*CoreAndFilter3xUsingOld3xAgentTest*"}) independently from these extra environments. This keeps
* the default job/runtime smaller while still allowing coverage for Tomcat Java 17 and WildFly Java
* 8 when desired.
*
* <p>The outer class intentionally contains no tests; only the nested classes are executed.
*/
public class CoreAndFilter3xUsingOld3xAgentSplitTest {
Copy link
Member

@trask trask Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add comment explaining why it's split?


@Environment(TOMCAT_8_JAVA_17)
static class Tomcat8Java17Test extends CoreAndFilter3xUsingOld3xAgentTest {}

@Environment(TOMCAT_8_JAVA_17_OPENJ9)
static class Tomcat8Java17OpenJ9Test extends CoreAndFilter3xUsingOld3xAgentTest {}

// note: old 3.x agents don't support Java 19

@Environment(WILDFLY_13_JAVA_8)
static class Wildfly13Java8Test extends CoreAndFilter3xUsingOld3xAgentTest {}

@Environment(WILDFLY_13_JAVA_8_OPENJ9)
static class Wildfly13Java8OpenJ9Test extends CoreAndFilter3xUsingOld3xAgentTest {}
}
18 changes: 0 additions & 18 deletions .../java/com/microsoft/applicationinsights/smoketest/CoreAndFilter3xUsingOld3xAgentTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,8 @@

import static com.microsoft.applicationinsights.smoketest.EnvironmentValue.TOMCAT_8_JAVA_11;
import static com.microsoft.applicationinsights.smoketest.EnvironmentValue.TOMCAT_8_JAVA_11_OPENJ9;
import static com.microsoft.applicationinsights.smoketest.EnvironmentValue.TOMCAT_8_JAVA_17;
import static com.microsoft.applicationinsights.smoketest.EnvironmentValue.TOMCAT_8_JAVA_17_OPENJ9;
import static com.microsoft.applicationinsights.smoketest.EnvironmentValue.TOMCAT_8_JAVA_8;
import static com.microsoft.applicationinsights.smoketest.EnvironmentValue.TOMCAT_8_JAVA_8_OPENJ9;
import static com.microsoft.applicationinsights.smoketest.EnvironmentValue.WILDFLY_13_JAVA_8;
import static com.microsoft.applicationinsights.smoketest.EnvironmentValue.WILDFLY_13_JAVA_8_OPENJ9;
import static java.util.concurrent.TimeUnit.SECONDS;
import static org.assertj.core.api.Assertions.assertThat;

Expand Down Expand Up @@ -537,18 +533,4 @@ static class Tomcat8Java11Test extends CoreAndFilter3xUsingOld3xAgentTest {}

@Environment(TOMCAT_8_JAVA_11_OPENJ9)
static class Tomcat8Java11OpenJ9Test extends CoreAndFilter3xUsingOld3xAgentTest {}

@Environment(TOMCAT_8_JAVA_17)
static class Tomcat8Java17Test extends CoreAndFilter3xUsingOld3xAgentTest {}

@Environment(TOMCAT_8_JAVA_17_OPENJ9)
static class Tomcat8Java17OpenJ9Test extends CoreAndFilter3xUsingOld3xAgentTest {}

// note: old 3.x agents don't support Java 19

@Environment(WILDFLY_13_JAVA_8)
static class Wildfly13Java8Test extends CoreAndFilter3xUsingOld3xAgentTest {}

@Environment(WILDFLY_13_JAVA_8_OPENJ9)
static class Wildfly13Java8OpenJ9Test extends CoreAndFilter3xUsingOld3xAgentTest {}
}