Closed
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an authentication scope error by standardizing the return type of getMcpPlatformAuthenticationScope() to return string[] instead of string, making it consistent with similar authentication scope functions in the codebase.
- Changed
getMcpPlatformAuthenticationScope()return type fromstringtostring[] - Updated the caller to use the scope array directly instead of wrapping it
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/agents-a365-runtime/src/environment-utils.ts | Modified getMcpPlatformAuthenticationScope() to return string[] by wrapping the scope value in an array |
| packages/agents-a365-runtime/src/agentic-authorization-service.ts | Updated to use the scope array directly (removed redundant array wrapping) since getMcpPlatformAuthenticationScope() now returns an array |
Contributor
|
Fixed in other PR - closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.